<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/15290">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Transceiver: Fix idle ul burst indications being dropped<br><br>pullRadioVector() should return true on idle frames because those<br>indications may be handled by upper layers (TRXDv1). Clarify return code<br>in function documentation.<br><br>Change-Id: If592ed1c04cf7e995f656b313f60edd4d40d1bfd<br>---<br>M Transceiver52M/Transceiver.cpp<br>1 file changed, 2 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp</span><br><span>index 0a78c11..9a1c446 100644</span><br><span>--- a/Transceiver52M/Transceiver.cpp</span><br><span>+++ b/Transceiver52M/Transceiver.cpp</span><br><span>@@ -587,6 +587,7 @@</span><br><span> /*</span><br><span>  * Pull bursts from the FIFO and handle according to the slot</span><br><span>  * and burst correlation type. Equalzation is currently disabled.</span><br><span style="color: hsl(120, 100%, 40%);">+ * returns true on success (bi filled), false on error (bi content undefined).</span><br><span>  */</span><br><span> bool Transceiver::pullRadioVector(size_t chan, struct trx_ul_burst_ind *bi)</span><br><span> {</span><br><span>@@ -708,7 +709,7 @@</span><br><span> ret_idle:</span><br><span>   bi->idle = true;</span><br><span>   delete radio_burst;</span><br><span style="color: hsl(0, 100%, 40%);">-  return false;</span><br><span style="color: hsl(120, 100%, 40%);">+  return true;</span><br><span> }</span><br><span> </span><br><span> void Transceiver::reset()</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/15290">change 15290</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/15290"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: If592ed1c04cf7e995f656b313f60edd4d40d1bfd </div>
<div style="display:none"> Gerrit-Change-Number: 15290 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>