<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15282">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ggsn: Introduce test TC_pdp_act_restart_ctr_echo<br><br>VTY functionalities to enable and disable echo requests in osmo-ggsn are<br>added too as part of the test.<br><br>Depends: osmo-ggsn.git Id2c84165dc59dff495106758146a701ca488834f<br>Related: OS#4165<br>Change-Id: Ia37e48e7ff9ad063f9eabf447f8a6a0a3fc380d9<br>---<br>M ggsn_tests/GGSN_Tests.ttcn<br>M ggsn_tests/expected-results.xml<br>2 files changed, 86 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/82/15282/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn_tests/GGSN_Tests.ttcn b/ggsn_tests/GGSN_Tests.ttcn</span><br><span>index ae92626..e294fb7 100644</span><br><span>--- a/ggsn_tests/GGSN_Tests.ttcn</span><br><span>+++ b/ggsn_tests/GGSN_Tests.ttcn</span><br><span>@@ -64,6 +64,13 @@</span><br><span> * The tests expect to be able to send ping packets between any two simulated MS within the same</span><br><span> * address range. This requires IP forwarding to be enabled on the corresponding tun interfaces.</span><br><span> */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Whether ggsn supports "(no) echo-interval" VTY command</span><br><span style="color: hsl(120, 100%, 40%);">+ * (osmo-ggsn.git Id2c84165dc59dff495106758146a701ca488834f).</span><br><span style="color: hsl(120, 100%, 40%);">+ * This option can be dropped after osmo-ggsn release > 1.4.0 exists.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+ boolean m_ggsn_supports_echo_interval := true;</span><br><span> }</span><br><span> </span><br><span> type set PdpContext {</span><br><span>@@ -107,6 +114,7 @@</span><br><span> </span><br><span> port TELNETasp_PT GGSNVTY;</span><br><span> var boolean use_gtpu_txseq := false;</span><br><span style="color: hsl(120, 100%, 40%);">+ var boolean g_use_echo := false;</span><br><span> }</span><br><span> </span><br><span> private function f_init_vty() runs on GT_CT {</span><br><span>@@ -159,6 +167,17 @@</span><br><span> return true;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ private function f_vty_enable_echo_interval(boolean enable) runs on GT_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_enter_config(GGSNVTY);</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(GGSNVTY, "ggsn ggsn0");</span><br><span style="color: hsl(120, 100%, 40%);">+ if (enable) {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(GGSNVTY, "echo-interval 5");</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(GGSNVTY, "no echo-interval");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_transceive(GGSNVTY, "end");</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> function f_init() runs on GT_CT {</span><br><span> if (g_initialized == true) {</span><br><span> return;</span><br><span>@@ -184,20 +203,22 @@</span><br><span> </span><br><span> f_init_vty();</span><br><span> f_vty_set_gpdu_txseq(use_gtpu_txseq);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (m_ggsn_supports_echo_interval) {</span><br><span style="color: hsl(120, 100%, 40%);">+ f_vty_enable_echo_interval(g_use_echo);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span> </span><br><span> /* Altstep implementing responses to any incoming echo requests */</span><br><span> altstep pingpong() runs on GT_CT {</span><br><span> var Gtp1cUnitdata ud;</span><br><span> var Gtp1uUnitdata udu;</span><br><span style="color: hsl(0, 100%, 40%);">- [] GTPC.receive(tr_GTPC_PING(?)) -> value ud {</span><br><span style="color: hsl(120, 100%, 40%);">+ [g_use_echo] GTPC.receive(tr_GTPC_PING(?)) -> value ud {</span><br><span> var uint16_t seq := oct2int(ud.gtpc.opt_part.sequenceNumber);</span><br><span style="color: hsl(0, 100%, 40%);">- GTPC.send(ts_GTPC_PONG(ud.peer, seq, '00'O));</span><br><span style="color: hsl(120, 100%, 40%);">+ GTPC.send(ts_GTPC_PONG(ud.peer, seq, g_restart_ctr));</span><br><span> repeat;</span><br><span> };</span><br><span style="color: hsl(0, 100%, 40%);">- [] GTPU.receive(tr_GTPU_PING(?)) -> value udu {</span><br><span style="color: hsl(0, 100%, 40%);">- var uint16_t seq := oct2int(udu.gtpu.opt_part.sequenceNumber);</span><br><span style="color: hsl(0, 100%, 40%);">- GTPU.send(ts_GTPU_PONG(udu.peer, seq, '00'O));</span><br><span style="color: hsl(120, 100%, 40%);">+ [not g_use_echo] GTPC.receive(tr_GTPC_PING(?)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail, "GTP Echo Req rceived but not enabled in VTY");</span><br><span> };</span><br><span> [] T_default.timeout { setverdict(fail); };</span><br><span> }</span><br><span>@@ -307,6 +328,35 @@</span><br><span> T_default.stop;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ function f_pdp_ctx_exp_del_req(PdpContext ctx, template (omit) OCT1 expect_cause := omit, boolean expect_teardown := false) runs on GT_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var Gtp1cUnitdata ud;</span><br><span style="color: hsl(120, 100%, 40%);">+ var default d;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ T_default.start;</span><br><span style="color: hsl(120, 100%, 40%);">+ d := activate(pingpong());</span><br><span style="color: hsl(120, 100%, 40%);">+ alt {</span><br><span style="color: hsl(120, 100%, 40%);">+ [] GTPC.receive(tr_GTPC_MsgType(g_peer_c, deletePDPContextRequest, ctx.teic)) -> value ud {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (istemplatekind(expect_cause, "omit") and not ispresent(ud.gtpc.gtpc_pdu.deletePDPContextRequest.cause.causevalue)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else if (not istemplatekind(expect_cause, "omit") and</span><br><span style="color: hsl(120, 100%, 40%);">+ ispresent(ud.gtpc.gtpc_pdu.deletePDPContextRequest.cause.causevalue) and</span><br><span style="color: hsl(120, 100%, 40%);">+ ud.gtpc.gtpc_pdu.deletePDPContextRequest.cause.causevalue == valueof(expect_cause)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (expect_teardown == ispresent(ud.gtpc.gtpc_pdu.deletePDPContextRequest.tearDownIndicator)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(fail);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ deactivate(d);</span><br><span style="color: hsl(120, 100%, 40%);">+ T_default.stop;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> function f_pdp_ctx_del(PdpContext ctx, template BIT1 teardown_ind, OCT1 expect_causevalue := '80'O) runs on GT_CT {</span><br><span> var Gtp1cUnitdata ud;</span><br><span> var default d;</span><br><span>@@ -1330,6 +1380,32 @@</span><br><span> f_pdp_ctx_del(ctx, '1'B, cause_nonexistent);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ /* Activate PDP context + trigger Recovery procedure through EchoResp */</span><br><span style="color: hsl(120, 100%, 40%);">+ testcase TC_pdp_act_restart_ctr_echo() runs on GT_CT {</span><br><span style="color: hsl(120, 100%, 40%);">+ var Gtp1cUnitdata ud;</span><br><span style="color: hsl(120, 100%, 40%);">+ g_use_echo := true;</span><br><span style="color: hsl(120, 100%, 40%);">+ f_init();</span><br><span style="color: hsl(120, 100%, 40%);">+ var PdpContext ctx := valueof(t_DefinePDP(f_rnd_imsi('26242'H), '1234'O, c_ApnInternet, valueof(t_EuaIPv4Dyn)));</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pdp_ctx_act(ctx);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Wait to receive echo request and send initial Restart counter */</span><br><span style="color: hsl(120, 100%, 40%);">+ GTPC.receive(tr_GTPC_PING(?)) -> value ud {</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint16_t seq := oct2int(ud.gtpc.opt_part.sequenceNumber);</span><br><span style="color: hsl(120, 100%, 40%);">+ GTPC.send(ts_GTPC_PONG(ud.peer, seq, g_restart_ctr));</span><br><span style="color: hsl(120, 100%, 40%);">+ };</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Wait to receive second echo request and send incremented Restart</span><br><span style="color: hsl(120, 100%, 40%);">+ counter. This will fake a restarted SGSN, and pdp ctx allocated</span><br><span style="color: hsl(120, 100%, 40%);">+ should be released by GGSN */</span><br><span style="color: hsl(120, 100%, 40%);">+ g_restart_ctr := int2oct(oct2int(g_restart_ctr) + 1, 1);</span><br><span style="color: hsl(120, 100%, 40%);">+ GTPC.receive(tr_GTPC_PING(?)) -> value ud {</span><br><span style="color: hsl(120, 100%, 40%);">+ var uint16_t seq := oct2int(ud.gtpc.opt_part.sequenceNumber);</span><br><span style="color: hsl(120, 100%, 40%);">+ GTPC.send(ts_GTPC_PONG(ud.peer, seq, g_restart_ctr));</span><br><span style="color: hsl(120, 100%, 40%);">+ };</span><br><span style="color: hsl(120, 100%, 40%);">+ f_pdp_ctx_exp_del_req(ctx, omit, true);</span><br><span style="color: hsl(120, 100%, 40%);">+ setverdict(pass);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> control {</span><br><span> execute(TC_pdp4_act_deact());</span><br><span> execute(TC_pdp4_act_deact_ipcp());</span><br><span>@@ -1358,5 +1434,9 @@</span><br><span> </span><br><span> execute(TC_echo_req_resp());</span><br><span> execute(TC_act_deact_retrans_duplicate());</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (m_ggsn_supports_echo_interval) {</span><br><span style="color: hsl(120, 100%, 40%);">+ execute(TC_pdp_act_restart_ctr_echo());</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span> }</span><br><span>diff --git a/ggsn_tests/expected-results.xml b/ggsn_tests/expected-results.xml</span><br><span>index 374cde0..c31c14a 100644</span><br><span>--- a/ggsn_tests/expected-results.xml</span><br><span>+++ b/ggsn_tests/expected-results.xml</span><br><span>@@ -24,4 +24,5 @@</span><br><span> <testcase classname='GGSN_Tests' name='TC_pdp46_act_deact_apn4' time='MASKED'/></span><br><span> <testcase classname='GGSN_Tests' name='TC_echo_req_resp' time='MASKED'/></span><br><span> <testcase classname='GGSN_Tests' name='TC_act_deact_retrans_duplicate' time='MASKED'/></span><br><span style="color: hsl(120, 100%, 40%);">+ <testcase classname='GGSN_Tests' name='TC_pdp_act_restart_ctr_echo' time='MASKED'/></span><br><span> </testsuite></span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15282">change 15282</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15282"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia37e48e7ff9ad063f9eabf447f8a6a0a3fc380d9 </div>
<div style="display:none"> Gerrit-Change-Number: 15282 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>