<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15264">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_gmm.c: Add spec document to function documentation<br><br>Change-Id: Ibb89499e9c1ab588336df34fde26faf3fbf2c72c<br>---<br>M src/gprs/gprs_gmm.c<br>1 file changed, 16 insertions(+), 16 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c</span><br><span>index 1d8ec57..e44b3ec 100644</span><br><span>--- a/src/gprs/gprs_gmm.c</span><br><span>+++ b/src/gprs/gprs_gmm.c</span><br><span>@@ -674,7 +674,7 @@</span><br><span> return false;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* 3GPP TS 24.008 Section 9.4.9: Authentication and Ciphering Request */</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 9.4.9: Authentication and Ciphering Request */</span><br><span> int gsm48_tx_gmm_auth_ciph_req(struct sgsn_mm_ctx *mm,</span><br><span> const struct osmo_auth_vector *vec,</span><br><span> uint8_t key_seq, bool force_standby)</span><br><span>@@ -742,7 +742,7 @@</span><br><span> return gsm48_gmm_sendmsg(msg, 1, mm, false);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Section 9.4.11: Authentication and Ciphering Reject */</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 9.4.11: Authentication and Ciphering Reject */</span><br><span> static int gsm48_tx_gmm_auth_ciph_rej(struct sgsn_mm_ctx *mm)</span><br><span> {</span><br><span> struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 AUTH CIPH REJ");</span><br><span>@@ -815,7 +815,7 @@</span><br><span> return OSMO_AUTH_TYPE_NONE;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Section 9.4.10: Authentication and Ciphering Response */</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 9.4.10: Authentication and Ciphering Response */</span><br><span> static int gsm48_rx_gmm_auth_ciph_resp(struct sgsn_mm_ctx *ctx,</span><br><span> struct msgb *msg)</span><br><span> {</span><br><span>@@ -892,7 +892,7 @@</span><br><span> return osmo_fsm_inst_dispatch(ctx->gmm_att_req.fsm, E_AUTH_RESP_RECV_SUCCESS, NULL);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Section 9.4.10: Authentication and Ciphering Failure */</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 9.4.10: Authentication and Ciphering Failure */</span><br><span> static int gsm48_rx_gmm_auth_ciph_fail(struct sgsn_mm_ctx *ctx,</span><br><span> struct msgb *msg)</span><br><span> {</span><br><span>@@ -1357,7 +1357,7 @@</span><br><span> ctx->gmm_state = GMM_COMMON_PROC_INIT;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Section 9.4.1 Attach request */</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 9.4.1 Attach request */</span><br><span> static int gsm48_rx_gmm_att_req(struct sgsn_mm_ctx *ctx, struct msgb *msg,</span><br><span> struct gprs_llc_llme *llme)</span><br><span> {</span><br><span>@@ -1569,7 +1569,7 @@</span><br><span> return !!memcmp(gh_a, gh_b, GMM_ATTACH_REQ_LEN);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Section 4.7.4.1 / 9.4.5.2 MO Detach request */</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 4.7.4.1 / 9.4.5.2 MO Detach request */</span><br><span> static int gsm48_rx_gmm_det_req(struct sgsn_mm_ctx *ctx, struct msgb *msg)</span><br><span> {</span><br><span> struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_gmmh(msg);</span><br><span>@@ -1707,7 +1707,7 @@</span><br><span> }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* 3GPP TS 24.008 Section 4.7.13.4 Service request procedure not accepted by the</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 4.7.13.4 Service request procedure not accepted by the</span><br><span> * network. Returns true if MS has active PDP contexts in pdp_status */</span><br><span> bool pdp_status_has_active_nsapis(const uint8_t *pdp_status, const size_t pdp_status_len)</span><br><span> {</span><br><span>@@ -1919,7 +1919,7 @@</span><br><span> return rc;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* 3GPP TS 24.008 Section 9.4.20 Service request.</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 9.4.20 Service request.</span><br><span> * In Iu, a UE in PMM-IDLE mode can use GSM48_MT_GMM_SERVICE_REQ to switch back</span><br><span> * to PMM-CONNECTED mode. */</span><br><span> static int gsm48_rx_gmm_service_req(struct sgsn_mm_ctx *ctx, struct msgb *msg)</span><br><span>@@ -2009,7 +2009,7 @@</span><br><span> </span><br><span> process_ms_ctx_status(ctx, pdp_status);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- /* 3GPP TS 24.008 Section 4.7.13.4 Service request procedure not</span><br><span style="color: hsl(120, 100%, 40%);">+ /* 3GPP TS 24.008 § 4.7.13.4 Service request procedure not</span><br><span> * accepted by the network. Cause #40. If MS has PDP Contexts in</span><br><span> * Active state in pdp_status but there is no PDP contexts on</span><br><span> * SGSN side then Reject with the cause will force the mobile to</span><br><span>@@ -2403,7 +2403,7 @@</span><br><span> }</span><br><span> #endif</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Section 9.5.2: Activate PDP Context Accept */</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 9.5.2: Activate PDP Context Accept */</span><br><span> int gsm48_tx_gsm_act_pdp_acc(struct sgsn_pdp_ctx *pdp)</span><br><span> {</span><br><span> struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 PDP ACC");</span><br><span>@@ -2447,7 +2447,7 @@</span><br><span> return gsm48_gmm_sendmsg(msg, 0, pdp->mm, true);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Section 9.5.3: Activate PDP Context reject */</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 9.5.3: Activate PDP Context reject */</span><br><span> int gsm48_tx_gsm_act_pdp_rej(struct sgsn_mm_ctx *mm, uint8_t tid,</span><br><span> uint8_t cause, uint8_t pco_len, uint8_t *pco_v)</span><br><span> {</span><br><span>@@ -2472,7 +2472,7 @@</span><br><span> return gsm48_gmm_sendmsg(msg, 0, mm, true);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Section 9.5.8: Deactivate PDP Context Request */</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 9.5.8: Deactivate PDP Context Request */</span><br><span> static int _gsm48_tx_gsm_deact_pdp_req(struct sgsn_mm_ctx *mm, uint8_t tid,</span><br><span> uint8_t sm_cause, bool teardown)</span><br><span> {</span><br><span>@@ -2502,7 +2502,7 @@</span><br><span> return _gsm48_tx_gsm_deact_pdp_req(pdp->mm, pdp->ti, sm_cause, teardown);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Section 9.5.9: Deactivate PDP Context Accept */</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 9.5.9: Deactivate PDP Context Accept */</span><br><span> static int _gsm48_tx_gsm_deact_pdp_acc(struct sgsn_mm_ctx *mm, uint8_t tid)</span><br><span> {</span><br><span> struct msgb *msg = gsm48_msgb_alloc_name("GSM 04.08 PDP DET ACC");</span><br><span>@@ -2800,7 +2800,7 @@</span><br><span> gsm_cause, 0, NULL);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Section 9.5.1: Activate PDP Context Request */</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 9.5.1: Activate PDP Context Request */</span><br><span> static int gsm48_rx_gsm_act_pdp_req(struct sgsn_mm_ctx *mmctx,</span><br><span> struct msgb *_msg)</span><br><span> {</span><br><span>@@ -2837,7 +2837,7 @@</span><br><span> return rc;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Section 9.5.8: Deactivate PDP Context Request */</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 9.5.8: Deactivate PDP Context Request */</span><br><span> static int gsm48_rx_gsm_deact_pdp_req(struct sgsn_mm_ctx *mm, struct msgb *msg)</span><br><span> {</span><br><span> struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_gmmh(msg);</span><br><span>@@ -2859,7 +2859,7 @@</span><br><span> return sgsn_delete_pdp_ctx(pdp);</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-/* Section 9.5.9: Deactivate PDP Context Accept */</span><br><span style="color: hsl(120, 100%, 40%);">+/* 3GPP TS 24.008 § 9.5.9: Deactivate PDP Context Accept */</span><br><span> static int gsm48_rx_gsm_deact_pdp_ack(struct sgsn_mm_ctx *mm, struct msgb *msg)</span><br><span> {</span><br><span> struct gsm48_hdr *gh = (struct gsm48_hdr *) msgb_gmmh(msg);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15264">change 15264</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15264"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ibb89499e9c1ab588336df34fde26faf3fbf2c72c </div>
<div style="display:none"> Gerrit-Change-Number: 15264 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>