<p>pespin <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15215">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
neels: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tests: Introduce vty-transcript-test tests<br><br>Add a few commands to make sure it's working fine, and print all<br>available timers with default values.<br><br>Change-Id: Ifd092b9561d49be1f62769d95ba49f6e4aeb4066<br>---<br>M tests/Makefile.am<br>A tests/test_nodes.vty<br>2 files changed, 89 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/Makefile.am b/tests/Makefile.am</span><br><span>index 035cfb0..6c392af 100644</span><br><span>--- a/tests/Makefile.am</span><br><span>+++ b/tests/Makefile.am</span><br><span>@@ -33,6 +33,7 @@</span><br><span> $(TESTSUITE) \</span><br><span> vty_test_runner.py \</span><br><span> ctrl_test_runner.py \</span><br><span style="color: hsl(120, 100%, 40%);">+ test_nodes.vty \</span><br><span> $(NULL)</span><br><span> </span><br><span> TESTSUITE = $(srcdir)/testsuite</span><br><span>@@ -43,16 +44,38 @@</span><br><span> </span><br><span> if ENABLE_EXT_TESTS</span><br><span> python-tests: $(BUILT_SOURCES)</span><br><span style="color: hsl(0, 100%, 40%);">- osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v</span><br><span style="color: hsl(0, 100%, 40%);">- osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v</span><br><span style="color: hsl(0, 100%, 40%);">- $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v</span><br><span style="color: hsl(0, 100%, 40%);">- $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v</span><br><span style="color: hsl(0, 100%, 40%);">- rm -f $(top_builddir)/sms.db $(top_builddir)/gsn_restart $(top_builddir)/gtphub_restart_count</span><br><span style="color: hsl(120, 100%, 40%);">+ $(MAKE) vty-test</span><br><span style="color: hsl(120, 100%, 40%);">+ $(MAKE) ctrl-python-test</span><br><span> else</span><br><span> python-tests: $(BUILT_SOURCES)</span><br><span> echo "Not running python-based tests (determined at configure-time)"</span><br><span> endif</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+vty-python-test: $(BUILT_SOURCES)</span><br><span style="color: hsl(120, 100%, 40%);">+ osmotestvty.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v</span><br><span style="color: hsl(120, 100%, 40%);">+ osmotestconfig.py -p $(abs_top_srcdir) -w $(abs_top_builddir) -v</span><br><span style="color: hsl(120, 100%, 40%);">+ $(srcdir)/vty_test_runner.py -w $(abs_top_builddir) -v</span><br><span style="color: hsl(120, 100%, 40%);">+ rm -f $(top_builddir)/sms.db $(top_builddir)/gsn_restart $(top_builddir)/gtphub_restart_count</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+# To update the VTY script from current application behavior,</span><br><span style="color: hsl(120, 100%, 40%);">+# pass -u to vty_script_runner.py by doing:</span><br><span style="color: hsl(120, 100%, 40%);">+# make vty-transcript-test U=-u</span><br><span style="color: hsl(120, 100%, 40%);">+vty-transcript-test:</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_verify_transcript_vty.py -v \</span><br><span style="color: hsl(120, 100%, 40%);">+ -n OsmoSGSN -p 4245 \</span><br><span style="color: hsl(120, 100%, 40%);">+ -r "$(top_builddir)/src/gprs/osmo-sgsn -c $(top_srcdir)/doc/examples/osmo-sgsn/osmo-sgsn.cfg" \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(U) $${T:-$(srcdir)/*.vty}</span><br><span style="color: hsl(120, 100%, 40%);">+ rm -f $(builddir)/sms.db $(builddir)/gsn_restart</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+# don't run multiple tests concurrently so that the ports don't conflict</span><br><span style="color: hsl(120, 100%, 40%);">+vty-test:</span><br><span style="color: hsl(120, 100%, 40%);">+ $(MAKE) vty-python-test</span><br><span style="color: hsl(120, 100%, 40%);">+ $(MAKE) vty-transcript-test</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ctrl-python-test: $(BUILT_SOURCES)</span><br><span style="color: hsl(120, 100%, 40%);">+ $(srcdir)/ctrl_test_runner.py -w $(abs_top_builddir) -v</span><br><span style="color: hsl(120, 100%, 40%);">+ rm -f $(top_builddir)/sms.db $(top_builddir)/gsn_restart $(top_builddir)/gtphub_restart_count</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> check-local: atconfig $(TESTSUITE)</span><br><span> $(SHELL) '$(TESTSUITE)' $(TESTSUITEFLAGS)</span><br><span> $(MAKE) $(AM_MAKEFLAGS) python-tests</span><br><span>diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty</span><br><span>new file mode 100644</span><br><span>index 0000000..630094f</span><br><span>--- /dev/null</span><br><span>+++ b/tests/test_nodes.vty</span><br><span>@@ -0,0 +1,61 @@</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoSGSN> enable</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoSGSN# show timer</span><br><span style="color: hsl(120, 100%, 40%);">+T3312 = 600 s Periodic RA Update timer (s) (default: 600 s)</span><br><span style="color: hsl(120, 100%, 40%);">+T3313 = 30 s Waiting for paging response timer (s) (default: 30 s)</span><br><span style="color: hsl(120, 100%, 40%);">+T3314 = 44 s Force to STANDBY on expiry timer (s) (default: 44 s)</span><br><span style="color: hsl(120, 100%, 40%);">+T3316 = 44 s AA-Ready timer (s) (default: 44 s)</span><br><span style="color: hsl(120, 100%, 40%);">+T3322 = 6 s Detach request -> accept timer (s) (default: 6 s)</span><br><span style="color: hsl(120, 100%, 40%);">+T3350 = 6 s Waiting for ATT/RAU/TMSI_COMPL timer (s) (default: 6 s)</span><br><span style="color: hsl(120, 100%, 40%);">+T3360 = 6 s Waiting for AUTH/CIPH response timer (s) (default: 6 s)</span><br><span style="color: hsl(120, 100%, 40%);">+T3370 = 6 s Waiting for IDENTITY response timer (s) (default: 6 s)</span><br><span style="color: hsl(120, 100%, 40%);">+T3385 = 8 s Wait for ACT PDP CTX REQ timer (s) (default: 8 s)</span><br><span style="color: hsl(120, 100%, 40%);">+T3386 = 8 s Wait for MODIFY PDP CTX ACK timer (s) (default: 8 s)</span><br><span style="color: hsl(120, 100%, 40%);">+T3395 = 8 s Wait for DEACT PDP CTX ACK timer (s) (default: 8 s)</span><br><span style="color: hsl(120, 100%, 40%);">+T3397 = 8 s Wait for DEACT AA PDP CTX ACK timer (s) (default: 8 s)</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoSGSN# configure terminal</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoSGSN(config)# list</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+ sgsn</span><br><span style="color: hsl(120, 100%, 40%);">+ ctrl</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+ ns</span><br><span style="color: hsl(120, 100%, 40%);">+ bssgp</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoSGSN(config)# sgsn</span><br><span style="color: hsl(120, 100%, 40%);">+OsmoSGSN(config-sgsn)# list</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span style="color: hsl(120, 100%, 40%);">+ gtp local-ip A.B.C.D</span><br><span style="color: hsl(120, 100%, 40%);">+ ggsn <0-255> remote-ip A.B.C.D</span><br><span style="color: hsl(120, 100%, 40%);">+ ggsn <0-255> gtp-version (0|1)</span><br><span style="color: hsl(120, 100%, 40%);">+ ggsn <0-255> echo-interval <1-36000></span><br><span style="color: hsl(120, 100%, 40%);">+ ggsn <0-255> no echo-interval</span><br><span style="color: hsl(120, 100%, 40%);">+ imsi-acl (add|del) IMSI</span><br><span style="color: hsl(120, 100%, 40%);">+ auth-policy (accept-all|closed|acl-only|remote)</span><br><span style="color: hsl(120, 100%, 40%);">+ authentication (optional|required)</span><br><span style="color: hsl(120, 100%, 40%);">+ encryption (GEA0|GEA1|GEA2|GEA3|GEA4)</span><br><span style="color: hsl(120, 100%, 40%);">+ gsup ipa-name NAME</span><br><span style="color: hsl(120, 100%, 40%);">+ gsup remote-ip A.B.C.D</span><br><span style="color: hsl(120, 100%, 40%);">+ gsup remote-port <0-65535></span><br><span style="color: hsl(120, 100%, 40%);">+ gsup oap-id <0-65535></span><br><span style="color: hsl(120, 100%, 40%);">+ gsup oap-k K</span><br><span style="color: hsl(120, 100%, 40%);">+ gsup oap-opc OPC</span><br><span style="color: hsl(120, 100%, 40%);">+ apn APNAME ggsn <0-255></span><br><span style="color: hsl(120, 100%, 40%);">+ apn APNAME imsi-prefix IMSIPRE ggsn <0-255></span><br><span style="color: hsl(120, 100%, 40%);">+ access-point-name NAME</span><br><span style="color: hsl(120, 100%, 40%);">+ no access-point-name NAME</span><br><span style="color: hsl(120, 100%, 40%);">+ cdr filename NAME</span><br><span style="color: hsl(120, 100%, 40%);">+ no cdr filename</span><br><span style="color: hsl(120, 100%, 40%);">+ cdr trap</span><br><span style="color: hsl(120, 100%, 40%);">+ no cdr trap</span><br><span style="color: hsl(120, 100%, 40%);">+ cdr interval <1-2147483647></span><br><span style="color: hsl(120, 100%, 40%);">+ ggsn dynamic</span><br><span style="color: hsl(120, 100%, 40%);">+ grx-dns-add A.B.C.D</span><br><span style="color: hsl(120, 100%, 40%);">+ timer [TNNNN] [(<0-2147483647>|default)]</span><br><span style="color: hsl(120, 100%, 40%);">+ no compression rfc1144</span><br><span style="color: hsl(120, 100%, 40%);">+ compression rfc1144 active slots <1-256></span><br><span style="color: hsl(120, 100%, 40%);">+ compression rfc1144 passive</span><br><span style="color: hsl(120, 100%, 40%);">+ no compression v42bis</span><br><span style="color: hsl(120, 100%, 40%);">+ compression v42bis active direction (ms|sgsn|both) codewords <512-65535> strlen <6-250></span><br><span style="color: hsl(120, 100%, 40%);">+ compression v42bis passive</span><br><span style="color: hsl(120, 100%, 40%);">+...</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15215">change 15215</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15215"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifd092b9561d49be1f62769d95ba49f6e4aeb4066 </div>
<div style="display:none"> Gerrit-Change-Number: 15215 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>