<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15259">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">libgtp: announce pdp ctx deletion upon CreatePdpCtx being rejected<br><br>The libgtp application  may have already allocated related resources<br>associated to the pdp context, so we need to signal its deletion in<br>order to let the application free the resources.<br><br>This should fix the duplication of pdp contexts seen in osmo-ggsn when<br>"show pdp-context" related VTY commands are used.<br>It was spotted due to some MS requesting a v4v6 context on a<br>v4-only APN, where first v4 address was allocated, and then upon v6<br>allocation create_context_ind() called<br>gtp_create_context_resp(GTPCAUSE_MISSING_APN) but the first address was<br>not freed. Upon receiving the callback, osmo-ggsn should now free the<br>related resources.<br><br>Related: OS#4154<br>Change-Id: I6c6215a4ce478afabc78ffaf5ffb0cf829e41226<br>---<br>M ggsn/ggsn.c<br>M gtp/gtp.c<br>2 files changed, 3 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/59/15259/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c</span><br><span>index 95371a2..d71855d 100644</span><br><span>--- a/ggsn/ggsn.c</span><br><span>+++ b/ggsn/ggsn.c</span><br><span>@@ -386,7 +386,7 @@</span><br><span>                      LOGPPDP(LOGL_ERROR, pdp, "Cannot find/free IP Pool member\n");</span><br><span>     }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (apn->cfg.gtpu_mode == APN_GTPU_MODE_KERNEL_GTP) {</span><br><span style="color: hsl(120, 100%, 40%);">+      if (apn && apn->cfg.gtpu_mode == APN_GTPU_MODE_KERNEL_GTP) {</span><br><span>              if (gtp_kernel_tunnel_del(pdp, apn->tun.cfg.dev_name)) {</span><br><span>                  LOGPPDP(LOGL_ERROR, pdp, "Cannot delete tunnel from kernel:%s\n",</span><br><span>                          strerror(errno));</span><br><span>diff --git a/gtp/gtp.c b/gtp/gtp.c</span><br><span>index 94c3245..becedd2 100644</span><br><span>--- a/gtp/gtp.c</span><br><span>+++ b/gtp/gtp.c</span><br><span>@@ -1296,9 +1296,8 @@</span><br><span>   /* Now send off a reply to the peer */</span><br><span>       gtp_create_pdp_resp(gsn, pdp->version, pdp, cause);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-      if (cause != GTPCAUSE_ACC_REQ) {</span><br><span style="color: hsl(0, 100%, 40%);">-                pdp_freepdp(pdp);</span><br><span style="color: hsl(0, 100%, 40%);">-       }</span><br><span style="color: hsl(120, 100%, 40%);">+     if (cause != GTPCAUSE_ACC_REQ)</span><br><span style="color: hsl(120, 100%, 40%);">+                gtp_freepdp(gsn, pdp);</span><br><span> </span><br><span>   return 0;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15259">change 15259</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15259"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6c6215a4ce478afabc78ffaf5ffb0cf829e41226 </div>
<div style="display:none"> Gerrit-Change-Number: 15259 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>