<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15252">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Introduce LOGTUN log helper<br><br>Change-Id: I237acdee0be19498804e0d509c610f4e0454ba72<br>---<br>M ggsn/ggsn.c<br>M ggsn/ggsn.h<br>2 files changed, 8 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/52/15252/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c</span><br><span>index 35f2527..a8c9847 100644</span><br><span>--- a/ggsn/ggsn.c</span><br><span>+++ b/ggsn/ggsn.c</span><br><span>@@ -556,7 +556,7 @@</span><br><span>          pool = apn->v6.pool;</span><br><span>              break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                LOGP(DTUN, LOGL_NOTICE, "non-IPv%u packet received from tun\n", iph->version);</span><br><span style="color: hsl(120, 100%, 40%);">+           LOGTUN(LOGL_NOTICE, tun, "non-IPv%u packet received\n", iph->version);</span><br><span>          return -1;</span><br><span>   }</span><br><span> </span><br><span>@@ -564,15 +564,15 @@</span><br><span>        if (!pool)</span><br><span>           return 0;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   DEBUGP(DTUN, "Received packet for APN(%s) from tun %s", apn->cfg.name, tun->devname);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>        if (ippool_getip(pool, &ipm, &dst)) {</span><br><span style="color: hsl(0, 100%, 40%);">-           DEBUGPC(DTUN, " with no PDP contex! (%s)\n", iph->version == 4 ?</span><br><span style="color: hsl(120, 100%, 40%);">+         LOGTUN(LOGL_DEBUG, tun, "Received packet for APN(%s) with no PDP contex! (%s)\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   apn->cfg.name,</span><br><span style="color: hsl(120, 100%, 40%);">+                     iph->version == 4 ?</span><br><span>                       inet_ntop(AF_INET, &iph->saddr, straddr, sizeof(straddr)) :</span><br><span>                   inet_ntop(AF_INET6, &ip6h->ip6_src, straddr, sizeof(straddr)));</span><br><span>               return 0;</span><br><span>    }</span><br><span style="color: hsl(0, 100%, 40%);">-       DEBUGPC(DTUN, "\n");</span><br><span style="color: hsl(120, 100%, 40%);">+        LOGTUN(LOGL_DEBUG, tun, "Received packet for APN(%s)\n", apn->cfg.name);</span><br><span> </span><br><span>    if (ipm->peer)               /* Check if a peer protocol is defined */</span><br><span>            gtp_data_req(apn->ggsn->gsn, (struct pdp_t *)ipm->peer, pack, len);</span><br><span>diff --git a/ggsn/ggsn.h b/ggsn/ggsn.h</span><br><span>index 88fd8b9..6155b30 100644</span><br><span>--- a/ggsn/ggsn.h</span><br><span>+++ b/ggsn/ggsn.h</span><br><span>@@ -153,3 +153,6 @@</span><br><span>  LOGP(DGGSN, level, "GGSN(%s): " fmt, (ggsn)->cfg.name, ## args)</span><br><span> </span><br><span> #define LOGPPDP(level, pdp, fmt, args...) LOGPDPX(DGGSN, level, pdp, fmt, ## args)</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define LOGTUN(level, tun, fmt, args...) \</span><br><span style="color: hsl(120, 100%, 40%);">+  LOGP(DTUN, level, "TUN(%s): " fmt, (tun)->devname, ## args)</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15252">change 15252</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15252"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I237acdee0be19498804e0d509c610f4e0454ba72 </div>
<div style="display:none"> Gerrit-Change-Number: 15252 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>