<p>pespin <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15212">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  lynxis lazus: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_gmm: Avoid spaces in fsm events and enum strings<br><br>FSM doesn't expect receiving event names containing spaces (log lines<br>generated are confusing).<br><br>Similar for enums, it's better using code names to match easily and make<br>log lines more clear.<br><br>Change-Id: I16ede8bf8352b09bc772fd7b43fad2c2274b3ec1<br>---<br>M src/gprs/gprs_gmm.c<br>M src/gprs/gprs_gmm_attach.c<br>2 files changed, 17 insertions(+), 17 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_gmm.c b/src/gprs/gprs_gmm.c</span><br><span>index 2f27182..b8b0116 100644</span><br><span>--- a/src/gprs/gprs_gmm.c</span><br><span>+++ b/src/gprs/gprs_gmm.c</span><br><span>@@ -107,12 +107,12 @@</span><br><span> };</span><br><span> </span><br><span> static const struct value_string gprs_pmm_state_names[] = {</span><br><span style="color: hsl(0, 100%, 40%);">-   { PMM_DETACHED,         "PMM DETACH" },</span><br><span style="color: hsl(0, 100%, 40%);">-       { PMM_CONNECTED,        "PMM CONNECTED" },</span><br><span style="color: hsl(0, 100%, 40%);">-    { PMM_IDLE,             "PMM IDLE" },</span><br><span style="color: hsl(0, 100%, 40%);">- { MM_IDLE,              "MM IDLE" },</span><br><span style="color: hsl(0, 100%, 40%);">-  { MM_READY,             "MM READY" },</span><br><span style="color: hsl(0, 100%, 40%);">- { MM_STANDBY,           "MM STANDBY" },</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_VALUE_STRING(PMM_DETACHED),</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_VALUE_STRING(PMM_CONNECTED),</span><br><span style="color: hsl(120, 100%, 40%);">+     OSMO_VALUE_STRING(PMM_IDLE),</span><br><span style="color: hsl(120, 100%, 40%);">+  OSMO_VALUE_STRING(MM_IDLE),</span><br><span style="color: hsl(120, 100%, 40%);">+   OSMO_VALUE_STRING(MM_READY),</span><br><span style="color: hsl(120, 100%, 40%);">+  OSMO_VALUE_STRING(MM_STANDBY),</span><br><span>       { 0, NULL }</span><br><span> };</span><br><span> </span><br><span>diff --git a/src/gprs/gprs_gmm_attach.c b/src/gprs/gprs_gmm_attach.c</span><br><span>index 1ab11f7..2217b0a 100644</span><br><span>--- a/src/gprs/gprs_gmm_attach.c</span><br><span>+++ b/src/gprs/gprs_gmm_attach.c</span><br><span>@@ -316,17 +316,17 @@</span><br><span> };</span><br><span> </span><br><span> const struct value_string gmm_attach_req_fsm_event_names[] = {</span><br><span style="color: hsl(0, 100%, 40%);">-  { E_ATTACH_REQ_RECV,            "Received an attach request" },</span><br><span style="color: hsl(0, 100%, 40%);">-       { E_IDEN_RESP_RECV,             "Identity Request received" },</span><br><span style="color: hsl(0, 100%, 40%);">-        { E_AUTH_RESP_RECV_SUCCESS,     "Authentication Response received" },</span><br><span style="color: hsl(0, 100%, 40%);">- { E_AUTH_RESP_RECV_RESYNC,      "Authentication Failure with resync received" },</span><br><span style="color: hsl(0, 100%, 40%);">-      { E_ATTACH_ACCEPTED,            "Attach accepted" },</span><br><span style="color: hsl(0, 100%, 40%);">-  { E_ATTACH_ACCEPT_SENT,         "Attach accept sent" },</span><br><span style="color: hsl(0, 100%, 40%);">-       { E_ATTACH_COMPLETE_RECV,       "Attach complete received." },</span><br><span style="color: hsl(0, 100%, 40%);">-        { E_IU_SECURITY_CMD_COMPLETE,   "IU Security Command Complete received." },</span><br><span style="color: hsl(0, 100%, 40%);">-   { E_REJECT,                     "Reject the MS"},</span><br><span style="color: hsl(0, 100%, 40%);">-     { E_VLR_ANSWERED,               "VLR answered"},</span><br><span style="color: hsl(0, 100%, 40%);">-      { 0,                            NULL }</span><br><span style="color: hsl(120, 100%, 40%);">+        OSMO_VALUE_STRING(E_ATTACH_REQ_RECV),</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_VALUE_STRING(E_IDEN_RESP_RECV),</span><br><span style="color: hsl(120, 100%, 40%);">+  OSMO_VALUE_STRING(E_AUTH_RESP_RECV_SUCCESS),</span><br><span style="color: hsl(120, 100%, 40%);">+  OSMO_VALUE_STRING(E_AUTH_RESP_RECV_RESYNC),</span><br><span style="color: hsl(120, 100%, 40%);">+   OSMO_VALUE_STRING(E_ATTACH_ACCEPTED),</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_VALUE_STRING(E_ATTACH_ACCEPT_SENT),</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_VALUE_STRING(E_ATTACH_COMPLETE_RECV),</span><br><span style="color: hsl(120, 100%, 40%);">+    OSMO_VALUE_STRING(E_IU_SECURITY_CMD_COMPLETE),</span><br><span style="color: hsl(120, 100%, 40%);">+        OSMO_VALUE_STRING(E_REJECT),</span><br><span style="color: hsl(120, 100%, 40%);">+  OSMO_VALUE_STRING(E_VLR_ANSWERED),</span><br><span style="color: hsl(120, 100%, 40%);">+    { 0, NULL }</span><br><span> };</span><br><span> </span><br><span> void gmm_attach_allstate_action(struct osmo_fsm_inst *fi, uint32_t event, void *data) {</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15212">change 15212</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15212"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I16ede8bf8352b09bc772fd7b43fad2c2274b3ec1 </div>
<div style="display:none"> Gerrit-Change-Number: 15212 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>