<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15200">View Change</a></p><div style="white-space:pre-wrap">Approvals:
pespin: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">snow-3g.c: Mark all internal primitive functions as static<br><br>We don't need to pollute the public namespace<br><br>Change-Id: I55347320383b173d1aca622997e7cfb98cd9caff<br>---<br>M mme/snow-3g.c<br>1 file changed, 13 insertions(+), 13 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/mme/snow-3g.c b/mme/snow-3g.c</span><br><span>index 6d4fe2a..992b107 100644</span><br><span>--- a/mme/snow-3g.c</span><br><span>+++ b/mme/snow-3g.c</span><br><span>@@ -78,7 +78,7 @@</span><br><span> * See section 3.1.1 for details.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-u8 MULx(u8 V, u8 c)</span><br><span style="color: hsl(120, 100%, 40%);">+static u8 MULx(u8 V, u8 c)</span><br><span> {</span><br><span> if ( V & 0x80 )</span><br><span> return ( (V << 1) ^ c);</span><br><span>@@ -94,7 +94,7 @@</span><br><span> * See section 3.1.2 for details.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-u8 MULxPOW(u8 V, u8 i, u8 c)</span><br><span style="color: hsl(120, 100%, 40%);">+static u8 MULxPOW(u8 V, u8 i, u8 c)</span><br><span> {</span><br><span> if ( i == 0)</span><br><span> return V;</span><br><span>@@ -108,7 +108,7 @@</span><br><span> * See section 3.4.2 for details.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-u32 MULalpha(u8 c)</span><br><span style="color: hsl(120, 100%, 40%);">+static u32 MULalpha(u8 c)</span><br><span> {</span><br><span> return ( ( ((u32)MULxPOW(c, 23, 0xa9)) << 24 ) |</span><br><span> ( ((u32)MULxPOW(c, 245, 0xa9)) << 16 ) |</span><br><span>@@ -122,7 +122,7 @@</span><br><span> * See section 3.4.3 for details.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-u32 DIValpha(u8 c)</span><br><span style="color: hsl(120, 100%, 40%);">+static u32 DIValpha(u8 c)</span><br><span> {</span><br><span> return ( ( ((u32)MULxPOW(c, 16, 0xa9)) << 24 ) |</span><br><span> ( ((u32)MULxPOW(c, 39, 0xa9)) << 16 ) |</span><br><span>@@ -136,7 +136,7 @@</span><br><span> * See section 3.3.1.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-u32 S1(u32 w)</span><br><span style="color: hsl(120, 100%, 40%);">+static u32 S1(u32 w)</span><br><span> {</span><br><span> u8 r0=0, r1=0, r2=0, r3=0;</span><br><span> u8 srw0 = SR[ (u8)((w >> 24) & 0xff) ];</span><br><span>@@ -174,7 +174,7 @@</span><br><span> * See section 3.3.2.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-u32 S2(u32 w)</span><br><span style="color: hsl(120, 100%, 40%);">+static u32 S2(u32 w)</span><br><span> {</span><br><span> u8 r0=0, r1=0, r2=0, r3=0;</span><br><span> u8 sqw0 = SQ[ (u8)((w >> 24) & 0xff) ];</span><br><span>@@ -211,7 +211,7 @@</span><br><span> * See section 3.4.4.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void ClockLFSRInitializationMode(u32 F)</span><br><span style="color: hsl(120, 100%, 40%);">+static void ClockLFSRInitializationMode(u32 F)</span><br><span> {</span><br><span> u32 v = ( ( (LFSR_S0 << 8) & 0xffffff00 ) ^</span><br><span> ( MULalpha( (u8)((LFSR_S0>>24) & 0xff) ) ) ^</span><br><span>@@ -243,7 +243,7 @@</span><br><span> * See section 3.4.5.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void ClockLFSRKeyStreamMode()</span><br><span style="color: hsl(120, 100%, 40%);">+static void ClockLFSRKeyStreamMode()</span><br><span> {</span><br><span> u32 v = ( ( (LFSR_S0 << 8) & 0xffffff00 ) ^</span><br><span> ( MULalpha( (u8)((LFSR_S0>>24) & 0xff) ) ) ^</span><br><span>@@ -275,7 +275,7 @@</span><br><span> * See Section 3.4.6.</span><br><span> */</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-u32 ClockFSM()</span><br><span style="color: hsl(120, 100%, 40%);">+static u32 ClockFSM()</span><br><span> {</span><br><span> u32 F = ( ( LFSR_S15 + FSM_R1 ) & 0xffffffff ) ^ FSM_R2 ;</span><br><span> u32 r = ( FSM_R2 + ( FSM_R3 ^ LFSR_S5 ) ) & 0xffffffff ;</span><br><span>@@ -433,7 +433,7 @@</span><br><span> * function.</span><br><span> * See section 4.3.2 for details.</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-u64 MUL64x(u64 V, u64 c)</span><br><span style="color: hsl(120, 100%, 40%);">+static u64 MUL64x(u64 V, u64 c)</span><br><span> {</span><br><span> if ( V & 0x8000000000000000 )</span><br><span> return (V << 1) ^ c;</span><br><span>@@ -449,7 +449,7 @@</span><br><span> * A 64-bit memory is allocated which is to be freed by the calling function.</span><br><span> * See section 4.3.3 for details.</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-u64 MUL64xPOW(u64 V, u8 i, u64 c)</span><br><span style="color: hsl(120, 100%, 40%);">+static u64 MUL64xPOW(u64 V, u8 i, u64 c)</span><br><span> {</span><br><span> if ( i == 0)</span><br><span> return V; </span><br><span>@@ -466,7 +466,7 @@</span><br><span> * function.</span><br><span> * See section 4.3.4 for details.</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-u64 MUL64(u64 V, u64 P, u64 c)</span><br><span style="color: hsl(120, 100%, 40%);">+static u64 MUL64(u64 V, u64 P, u64 c)</span><br><span> {</span><br><span> u64 result = 0;</span><br><span> int i = 0;</span><br><span>@@ -484,7 +484,7 @@</span><br><span> * Output : an 8 bit mask.</span><br><span> * Prepares an 8 bit mask with required number of 1 bits on the MSB side.</span><br><span> */</span><br><span style="color: hsl(0, 100%, 40%);">-u8 mask8bit(int n)</span><br><span style="color: hsl(120, 100%, 40%);">+static u8 mask8bit(int n)</span><br><span> {</span><br><span> return 0xFF ^ ((1<<(8-n)) - 1);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15200">change 15200</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/15200"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I55347320383b173d1aca622997e7cfb98cd9caff </div>
<div style="display:none"> Gerrit-Change-Number: 15200 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>