<p>pespin <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15166">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  lynxis lazus: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gprs_sgsn.c: Warn upon llme free unexpected scenarios<br><br>May be useful to detect unexpected conditions which could end up in<br>memory leaks.<br><br>Related: OS#3957<br>Change-Id: I0d175501083ce458ff1c07ad38761d2cbf4ea470<br>---<br>M src/gprs/gprs_sgsn.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/gprs/gprs_sgsn.c b/src/gprs/gprs_sgsn.c</span><br><span>index e01bc5c..8f1e54a 100644</span><br><span>--- a/src/gprs/gprs_sgsn.c</span><br><span>+++ b/src/gprs/gprs_sgsn.c</span><br><span>@@ -362,7 +362,9 @@</span><br><span> </span><br><span>   if (llme) {</span><br><span>          /* TLLI unassignment, must be called after sgsn_mm_ctx_free */</span><br><span style="color: hsl(0, 100%, 40%);">-          gprs_llgmm_assign(llme, tlli, TLLI_UNASSIGNED);</span><br><span style="color: hsl(120, 100%, 40%);">+               OSMO_ASSERT(llme->tlli == tlli);</span><br><span style="color: hsl(120, 100%, 40%);">+           if (gprs_llgmm_unassign(llme) < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                 LOGMMCTXP(LOGL_ERROR, mm, "gprs_llgmm_unassign failed, llme not freed!\n");</span><br><span>        }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15166">change 15166</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sgsn/+/15166"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sgsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0d175501083ce458ff1c07ad38761d2cbf4ea470 </div>
<div style="display:none"> Gerrit-Change-Number: 15166 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>