<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">avoid bogus error logs when no cmd_timer is set<br><br>mncc.c often calls stop_cmd_timer() even if no timer is running. If no timer is<br>set, this causes bogus ERROR logs saying:<br>  Wanted response(<random>) but got (<msgtype>)<br><br>Instead do nothing if no timer is pending at all.<br><br>Change-Id: I70f85a71df55ab8618ed78864cefb6fe5b26f581<br>---<br>M src/mncc.c<br>1 file changed, 2 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/42/15142/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/mncc.c b/src/mncc.c</span><br><span>index f5a44d5..d223906 100644</span><br><span>--- a/src/mncc.c</span><br><span>+++ b/src/mncc.c</span><br><span>@@ -71,6 +71,8 @@</span><br><span> </span><br><span> static void stop_cmd_timer(struct mncc_call_leg *leg, uint32_t got_res)</span><br><span> {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!osmo_timer_pending(&leg->cmd_timeout))</span><br><span style="color: hsl(120, 100%, 40%);">+            return;</span><br><span>      if (leg->rsp_wanted != got_res) {</span><br><span>                 LOGP(DMNCC, LOGL_ERROR, "Wanted response(%s) but got(%s) for leg(%u)\n",</span><br><span>                   osmo_mncc_name(leg->rsp_wanted), osmo_mncc_name(got_res), leg->callref);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142">change 15142</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15142"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I70f85a71df55ab8618ed78864cefb6fe5b26f581 </div>
<div style="display:none"> Gerrit-Change-Number: 15142 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>