<p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/15143/4/src/mncc.c">File src/mncc.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15143/4/src/mncc.c@205">Patch Set #4, Line 205:</a> <code style="font-family:monospace,monospace">static void update_rtp(struct call_leg *_leg) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">No need to change it now, but this function would be a lot simpler by using a switch:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">static void update_rtp(struct call_leg *_leg) {<br>        struct mncc_call_leg *leg;</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">    LOGP(DMNCC, LOGL_DEBUG, "UPDATE RTP for LEG Type (%u)\n", _leg->type);<br>        switch (_leg->type) {<br> case: CALL_TYPE_MNCC:<br>          leg = (struct mncc_call_leg *) _leg;<br>         struct call_leg *other = call_leg_other(&leg->base);<br>           if (!other)<br>                   goto ret_release;<br>                break;<br>        case CALL_TYPE_SIP:<br>                leg = (struct mncc_call_leg *) call_leg_other(_leg);<br>          if (!leg)<br>                     goto ret_release;<br>                break;<br>        default:<br>               OSMO_ASSERT(false);<br>        }<br>      <br>        send_rtp_connect(leg, other);<br>        return;<br>ret_release:<br>      LOGP(DMNCC, LOGL_ERROR, "Failed to find other leg.\n");<br>        _leg->release_call(_leg);<br>}</pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/15143/4/src/mncc.c@228">Patch Set #4, Line 228:</a> <code style="font-family:monospace,monospace">            _leg->release_call(_leg);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Wrong indentation here.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143">change 15143</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15143"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6f1f26533a25c93f243090bc02f1bc83b9108d42 </div>
<div style="display:none"> Gerrit-Change-Number: 15143 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 09 Aug 2019 11:11:09 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>