<p>neels has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/15111">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vlr_lu_fsm: fix missing event for IMEISV<br><br>Event VLR_ULA_E_ID_IMEISV is listed as permitted in VLR_ULA_S_WAIT_LU_COMPL,<br>but is missing from the switch() on the incoming event. So, sending an IMEISV<br>identity during the WAIT_LU_COMPL state would crash osmo-msc.<br><br>When receiving an IMEISV, vlr_subscr_set_imeisv() in turn calls<br>vlr_subscr_set_imei(), so as far as the lu_fsm is concerned, receiving an<br>IMEISV is identical to receiving an IMEI, and it can continue to send a Check<br>IMEI request to the HLR. Thus simply add VLR_ULA_E_ID_IMEISV to the<br>VLR_ULA_E_ID_IMEI switch case.<br><br>Change-Id: I11106cb108a4b1406ff9a8b8ff5761440a274dad<br>---<br>M src/libvlr/vlr_lu_fsm.c<br>1 file changed, 1 insertion(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/11/15111/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libvlr/vlr_lu_fsm.c b/src/libvlr/vlr_lu_fsm.c</span><br><span>index 87bf7a5..454709f 100644</span><br><span>--- a/src/libvlr/vlr_lu_fsm.c</span><br><span>+++ b/src/libvlr/vlr_lu_fsm.c</span><br><span>@@ -1253,6 +1253,7 @@</span><br><span>                                  LU_COMPL_VLR_E_NEW_TMSI_ACK, NULL);</span><br><span>           break;</span><br><span>       case VLR_ULA_E_ID_IMEI:</span><br><span style="color: hsl(120, 100%, 40%);">+       case VLR_ULA_E_ID_IMEISV:</span><br><span>            /* Got the IMEI from ME, now send it to HLR */</span><br><span>               vlr_subscr_tx_req_check_imei(lfp->vsub);</span><br><span>          break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/15111">change 15111</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/15111"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I11106cb108a4b1406ff9a8b8ff5761440a274dad </div>
<div style="display:none"> Gerrit-Change-Number: 15111 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>