<p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c">File src/mncc.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14997/1/src/mncc.c@191">Patch Set #1, Line 191:</a> <code style="font-family:monospace,monospace">      struct in_addr net = { .s_addr = other->ip };</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Well, according to existing code [mncc. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">just making notes...</p><p style="white-space: pre-wrap; word-wrap: break-word;">in sdp_extract_sdp, the code is:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">            struct in_addr addr;<br>          inet_aton(conn->c_address, &addr);<br>             leg->base.ip = addr.s_addr;</pre><p style="white-space: pre-wrap; word-wrap: break-word;">so the values stored in (struct call)->ip are always network byte order. but then, the original code was:</p><p style="white-space: pre-wrap; word-wrap: break-word;">mncc.ip = htonl(other->ip);<br>so this is wrong, no?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997">change 14997</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/14997"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I2620cce245be199d849d8fad3fc998c96c243f6b </div>
<div style="display:none"> Gerrit-Change-Number: 14997 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 06 Aug 2019 11:55:04 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Comment-In-Reply-To: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>