<p>keith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15068">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Fix bug with MO calls not connecting.<br><br>Fixes a bug I introduced in 5f73c2033b6b4e690f30292020d7361f48b5f2c2<br>where we would not call mncc_call_leg_connect() on receiving 200 from<br>SIP side, and therefore never send MNCC_SETUP_RSP to the MS<br><br>Change-Id: Ic7cc56c0d68a27eb1229c0c4aa1fa54d00b660b6<br>---<br>M src/sip.c<br>1 file changed, 5 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-sip-connector refs/changes/68/15068/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/sip.c b/src/sip.c</span><br><span>index b652b4b..4eb7689 100644</span><br><span>--- a/src/sip.c</span><br><span>+++ b/src/sip.c</span><br><span>@@ -332,11 +332,13 @@</span><br><span>           if (status == 180 || status == 183)</span><br><span>                  call_progress(leg, sip, status);</span><br><span>             else if (status == 200) {</span><br><span style="color: hsl(0, 100%, 40%);">-                       struct sip_call_leg *leg = sip_find_leg(nh);</span><br><span style="color: hsl(0, 100%, 40%);">-                    if (leg)</span><br><span style="color: hsl(120, 100%, 40%);">+                      if (leg->state == SIP_CC_CONNECTED || leg->state == SIP_CC_HOLD) {</span><br><span style="color: hsl(120, 100%, 40%);">+                              /* This 200 is a response to our re-INVITE on</span><br><span style="color: hsl(120, 100%, 40%);">+                          * a connected call. We just need to ACK it. */</span><br><span>                              nua_ack(leg->nua_handle, TAG_END());</span><br><span style="color: hsl(0, 100%, 40%);">-                 else</span><br><span style="color: hsl(120, 100%, 40%);">+                  } else {</span><br><span>                             call_connect(leg, sip);</span><br><span style="color: hsl(120, 100%, 40%);">+                       }</span><br><span>            }</span><br><span>            else if (status >= 300) {</span><br><span>                         struct call_leg *other = call_leg_other(&leg->base);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15068">change 15068</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15068"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic7cc56c0d68a27eb1229c0c4aa1fa54d00b660b6 </div>
<div style="display:none"> Gerrit-Change-Number: 15068 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>