<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15049">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  keith: Looks good to me, but someone else must approve
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds<br><br>Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its<br>parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,<br>definition in C file doesn't contain "(void)", which means number of<br>parameters is undefined and thus compiler doesn't complain. Let's remove<br>parameters from all callers before enforcing "(void)" on it.<br>API osmo_stats_vty_add_cmds never had a param list but has seem problem<br>(no "void"), so some users decided to pass a parameter to it.<br><br>Change-Id: Ie519d4a4064a95803c33fd6969b53e1ef27045b7<br>Related: OS#4138<br>---<br>M src/main.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/main.c b/src/main.c</span><br><span>index ab58a52..13fdd5d 100644</span><br><span>--- a/src/main.c</span><br><span>+++ b/src/main.c</span><br><span>@@ -133,8 +133,8 @@</span><br><span>        osmo_stats_init(tall_mncc_ctx);</span><br><span> </span><br><span>  mncc_sip_vty_init();</span><br><span style="color: hsl(0, 100%, 40%);">-    logging_vty_add_cmds(&mncc_sip_info);</span><br><span style="color: hsl(0, 100%, 40%);">-       osmo_stats_vty_add_cmds(&mncc_sip_info);</span><br><span style="color: hsl(120, 100%, 40%);">+  logging_vty_add_cmds();</span><br><span style="color: hsl(120, 100%, 40%);">+       osmo_stats_vty_add_cmds();</span><br><span> </span><br><span> </span><br><span>   /* parsing and setup */</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15049">change 15049</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-sip-connector/+/15049"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-sip-connector </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie519d4a4064a95803c33fd6969b53e1ef27045b7 </div>
<div style="display:none"> Gerrit-Change-Number: 15049 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>