<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15040">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds<br><br>Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its<br>parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,<br>definition in C file doesn't contain "(void)", which means number of<br>parameters is undefined and thus compiler doesn't complain. Let's remove<br>parameters from all callers before enforcing "(void)" on it.<br><br>Related: OS#4138<br>Change-Id: Iedd11f816002b686f0ddb54c0cf7ba4e229e21e3<br>---<br>M stp/stp_main.c<br>M tests/vty/ss7_asp_vty_test.c<br>2 files changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/40/15040/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/stp/stp_main.c b/stp/stp_main.c</span><br><span>index ff33959..a3e3a85 100644</span><br><span>--- a/stp/stp_main.c</span><br><span>+++ b/stp/stp_main.c</span><br><span>@@ -177,7 +177,7 @@</span><br><span> </span><br><span>        osmo_ss7_init();</span><br><span>     osmo_fsm_log_addr(false);</span><br><span style="color: hsl(0, 100%, 40%);">-       logging_vty_add_cmds(&log_info);</span><br><span style="color: hsl(120, 100%, 40%);">+  logging_vty_add_cmds();</span><br><span>      osmo_stats_vty_add_cmds();</span><br><span>   osmo_ss7_vty_init_sg(tall_stp_ctx);</span><br><span>  osmo_sccp_vty_init();</span><br><span>diff --git a/tests/vty/ss7_asp_vty_test.c b/tests/vty/ss7_asp_vty_test.c</span><br><span>index 6918df4..76ffcf2 100644</span><br><span>--- a/tests/vty/ss7_asp_vty_test.c</span><br><span>+++ b/tests/vty/ss7_asp_vty_test.c</span><br><span>@@ -162,7 +162,7 @@</span><br><span>     vty_init(&vty_info);</span><br><span> </span><br><span>         osmo_init_logging2(root_ctx, &log_info);</span><br><span style="color: hsl(0, 100%, 40%);">-    logging_vty_add_cmds(&log_info);</span><br><span style="color: hsl(120, 100%, 40%);">+  logging_vty_add_cmds();</span><br><span> </span><br><span>  osmo_ss7_init();</span><br><span>     osmo_ss7_vty_init_asp(root_ctx);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15040">change 15040</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-sccp/+/15040"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-sccp </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iedd11f816002b686f0ddb54c0cf7ba4e229e21e3 </div>
<div style="display:none"> Gerrit-Change-Number: 15040 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>