<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/openbsc/+/15054">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds<br><br>Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its<br>parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,<br>definition in C file doesn't contain "(void)", which means number of<br>parameters is undefined and thus compiler doesn't complain. Let's remove<br>parameters from all callers before enforcing "(void)" on it.<br>API osmo_stats_vty_add_cmds never had a param list but has seem problem<br>(no "void"), so some users decided to pass a parameter to it.<br><br>Change-Id: I7d9d477b983b0d62f01237d90acaa7ce455c3c3d<br>Related: OS#4138<br>---<br>M openbsc/src/libbsc/bsc_vty.c<br>M openbsc/src/osmo-bsc_mgcp/mgcp_main.c<br>M openbsc/src/osmo-bsc_nat/bsc_nat.c<br>3 files changed, 5 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c</span><br><span>index c71ea4a..55a716b 100644</span><br><span>--- a/openbsc/src/libbsc/bsc_vty.c</span><br><span>+++ b/openbsc/src/libbsc/bsc_vty.c</span><br><span>@@ -4335,7 +4335,7 @@</span><br><span>    install_element_ve(&show_paging_cmd);</span><br><span>    install_element_ve(&show_paging_group_cmd);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     logging_vty_add_cmds(NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+   logging_vty_add_cmds();</span><br><span>      osmo_stats_vty_add_cmds();</span><br><span> </span><br><span>       install_element(GSMNET_NODE, &cfg_net_neci_cmd);</span><br><span>diff --git a/openbsc/src/osmo-bsc_mgcp/mgcp_main.c b/openbsc/src/osmo-bsc_mgcp/mgcp_main.c</span><br><span>index 419f852..220efa3 100644</span><br><span>--- a/openbsc/src/osmo-bsc_mgcp/mgcp_main.c</span><br><span>+++ b/openbsc/src/osmo-bsc_mgcp/mgcp_main.c</span><br><span>@@ -222,8 +222,8 @@</span><br><span> </span><br><span>      vty_info.copyright = openbsc_copyright;</span><br><span>      vty_init(&vty_info);</span><br><span style="color: hsl(0, 100%, 40%);">-        logging_vty_add_cmds(NULL);</span><br><span style="color: hsl(0, 100%, 40%);">-     osmo_stats_vty_add_cmds(&log_info);</span><br><span style="color: hsl(120, 100%, 40%);">+       logging_vty_add_cmds();</span><br><span style="color: hsl(120, 100%, 40%);">+       osmo_stats_vty_add_cmds();</span><br><span>   mgcp_vty_init();</span><br><span> </span><br><span>         handle_options(argc, argv);</span><br><span>diff --git a/openbsc/src/osmo-bsc_nat/bsc_nat.c b/openbsc/src/osmo-bsc_nat/bsc_nat.c</span><br><span>index 2e2eac0..9bb33ad 100644</span><br><span>--- a/openbsc/src/osmo-bsc_nat/bsc_nat.c</span><br><span>+++ b/openbsc/src/osmo-bsc_nat/bsc_nat.c</span><br><span>@@ -1628,8 +1628,8 @@</span><br><span> </span><br><span>         vty_info.copyright = openbsc_copyright;</span><br><span>      vty_init(&vty_info);</span><br><span style="color: hsl(0, 100%, 40%);">-        logging_vty_add_cmds(NULL);</span><br><span style="color: hsl(0, 100%, 40%);">-     osmo_stats_vty_add_cmds(&log_info);</span><br><span style="color: hsl(120, 100%, 40%);">+       logging_vty_add_cmds();</span><br><span style="color: hsl(120, 100%, 40%);">+       osmo_stats_vty_add_cmds();</span><br><span>   bsc_nat_vty_init(nat);</span><br><span>       ctrl_vty_init(tall_bsc_ctx);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/openbsc/+/15054">change 15054</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/openbsc/+/15054"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: openbsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7d9d477b983b0d62f01237d90acaa7ce455c3c3d </div>
<div style="display:none"> Gerrit-Change-Number: 15054 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>