<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15042">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Remove undefined param passed to logging_vty_add_cmds<br><br>Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its<br>parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,<br>definition in C file doesn't contain "(void)", which means number of<br>parameters is undefined and thus compiler doesn't complain. Let's remove<br>parameters from all callers before enforcing "(void)" on it.<br><br>Related: OS#4138<br>Change-Id: I6d0dbbd83ce17ee798bfb6e30378ed1dbae19134<br>---<br>M src/hlr.c<br>M src/hlr_vty.c<br>M src/hlr_vty.h<br>3 files changed, 4 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/42/15042/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/hlr.c b/src/hlr.c</span><br><span>index 90cbac4..8b9dff1 100644</span><br><span>--- a/src/hlr.c</span><br><span>+++ b/src/hlr.c</span><br><span>@@ -846,7 +846,7 @@</span><br><span>        vty_init(&vty_info);</span><br><span>     ctrl_vty_init(hlr_ctx);</span><br><span>      handle_options(argc, argv);</span><br><span style="color: hsl(0, 100%, 40%);">-     hlr_vty_init(&hlr_log_info);</span><br><span style="color: hsl(120, 100%, 40%);">+      hlr_vty_init();</span><br><span> </span><br><span>  rc = vty_read_config_file(cmdline_opts.config_file, NULL);</span><br><span>   if (rc < 0) {</span><br><span>diff --git a/src/hlr_vty.c b/src/hlr_vty.c</span><br><span>index e6567cc..f7c5bc8 100644</span><br><span>--- a/src/hlr_vty.c</span><br><span>+++ b/src/hlr_vty.c</span><br><span>@@ -429,9 +429,9 @@</span><br><span>      }</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-void hlr_vty_init(const struct log_info *cat)</span><br><span style="color: hsl(120, 100%, 40%);">+void hlr_vty_init(void)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   logging_vty_add_cmds(cat);</span><br><span style="color: hsl(120, 100%, 40%);">+    logging_vty_add_cmds();</span><br><span>      osmo_talloc_vty_add_cmds();</span><br><span>  osmo_stats_vty_add_cmds();</span><br><span> </span><br><span>diff --git a/src/hlr_vty.h b/src/hlr_vty.h</span><br><span>index 1f3b87f..280b55a 100644</span><br><span>--- a/src/hlr_vty.h</span><br><span>+++ b/src/hlr_vty.h</span><br><span>@@ -35,4 +35,4 @@</span><br><span> </span><br><span> int hlr_vty_is_config_node(struct vty *vty, int node);</span><br><span> int hlr_vty_go_parent(struct vty *vty);</span><br><span style="color: hsl(0, 100%, 40%);">-void hlr_vty_init(const struct log_info *cat);</span><br><span style="color: hsl(120, 100%, 40%);">+void hlr_vty_init(void);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/15042">change 15042</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/15042"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6d0dbbd83ce17ee798bfb6e30378ed1dbae19134 </div>
<div style="display:none"> Gerrit-Change-Number: 15042 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>