<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15043">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Remove undefined param passed to {logging,osmo_stats}_vty_add_cmds<br><br>Since March 15th 2017, libosmocore API logging_vty_add_cmds() had its<br>parameter removed (c65c5b4ea075ef6cef11fff9442ae0b15c1d6af7). However,<br>definition in C file doesn't contain "(void)", which means number of<br>parameters is undefined and thus compiler doesn't complain. Let's remove<br>parameters from all callers before enforcing "(void)" on it.<br>API osmo_stats_vty_add_cmds never had a param list but has seem problem<br>(no "void"), so some users decided to pass a parameter to it.<br><br>Change-Id: I0a89586ce683ad060212355b37470c349992ec49<br>Related: OS#4138<br>---<br>M ggsn/ggsn.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/ggsn/ggsn.c b/ggsn/ggsn.c</span><br><span>index 1c6bc4d..95371a2 100644</span><br><span>--- a/ggsn/ggsn.c</span><br><span>+++ b/ggsn/ggsn.c</span><br><span>@@ -1267,9 +1267,9 @@</span><br><span>         osmo_stats_init(tall_ggsn_ctx);</span><br><span> </span><br><span>  vty_init(&g_vty_info);</span><br><span style="color: hsl(0, 100%, 40%);">-      logging_vty_add_cmds(NULL);</span><br><span style="color: hsl(120, 100%, 40%);">+   logging_vty_add_cmds();</span><br><span>      osmo_talloc_vty_add_cmds();</span><br><span style="color: hsl(0, 100%, 40%);">-     osmo_stats_vty_add_cmds(&log_info);</span><br><span style="color: hsl(120, 100%, 40%);">+       osmo_stats_vty_add_cmds();</span><br><span>   ggsn_vty_init();</span><br><span>     ctrl_vty_init(tall_ggsn_ctx);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15043">change 15043</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/15043"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I0a89586ce683ad060212355b37470c349992ec49 </div>
<div style="display:none"> Gerrit-Change-Number: 15043 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>