<p>osmith has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15031">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Makefile.asciidoc.inc: warnings check not default<br><br>Only check for asciidoc warnings in "make check" if<br>ASCIIDOC_WARNINGS_CHECK is set. Enable it in jenkins.sh by using the<br>new ./configure --enable-asciidoc-warnings-check parameter (similar to<br>--enable-werror in other Osmocom projects' configure.ac files).<br><br>Related: OS#4140<br>Change-Id: Iac993a0d1b17205397a1f1ef1a7bd3f9df739e36<br>---<br>M build/Makefile.asciidoc.inc<br>M configure.ac<br>M contrib/jenkins.sh<br>3 files changed, 14 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/changes/31/15031/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/build/Makefile.asciidoc.inc b/build/Makefile.asciidoc.inc</span><br><span>index 77f3b1d..7cb660f 100644</span><br><span>--- a/build/Makefile.asciidoc.inc</span><br><span>+++ b/build/Makefile.asciidoc.inc</span><br><span>@@ -75,7 +75,10 @@</span><br><span> TEXINPUTS="$(OSMO_GSM_MANUALS_DIR)" \</span><br><span> a2x -vv $(A2X_OPTS) $(notdir $<)</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-check: $(ASCIIDOC_CHECKS)</span><br><span style="color: hsl(120, 100%, 40%);">+check:</span><br><span style="color: hsl(120, 100%, 40%);">+ if [ -n "$$ASCIIDOC_WARNINGS_CHECK" ]; then \</span><br><span style="color: hsl(120, 100%, 40%);">+ $(MAKE) $(ASCIIDOC_CHECKS); \</span><br><span style="color: hsl(120, 100%, 40%);">+ fi</span><br><span> </span><br><span> $(ASCIIDOC_CHECKS): %.check: %.adoc %-docinfo.xml \</span><br><span> $(ASCIIDOCSTYLE) \</span><br><span>diff --git a/configure.ac b/configure.ac</span><br><span>index 9858af6..1017e9c 100644</span><br><span>--- a/configure.ac</span><br><span>+++ b/configure.ac</span><br><span>@@ -28,6 +28,15 @@</span><br><span> AC_MSG_ERROR("missing dependencies!")</span><br><span> fi</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+# Asciidoc warnings check (OS#4140)</span><br><span style="color: hsl(120, 100%, 40%);">+AC_ARG_ENABLE(asciidoc_warnings_check,</span><br><span style="color: hsl(120, 100%, 40%);">+ [AS_HELP_STRING(</span><br><span style="color: hsl(120, 100%, 40%);">+ [--enable-asciidoc-warnings-check],</span><br><span style="color: hsl(120, 100%, 40%);">+ [Fail the build if asciidoc prints any warnings]</span><br><span style="color: hsl(120, 100%, 40%);">+ )],</span><br><span style="color: hsl(120, 100%, 40%);">+ [asciidoc_warnings_check=$enableval], [asciidoc_warnings_check="no"])</span><br><span style="color: hsl(120, 100%, 40%);">+AM_CONDITIONAL([ASCIIDOC_WARNINGS_CHECK], [test x"$asciidoc_warnings_check" = x"yes"])</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> AC_OUTPUT(</span><br><span> osmo-gsm-manuals.pc</span><br><span> Makefile</span><br><span>diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh</span><br><span>index 0c40e2f..cf709b2 100755</span><br><span>--- a/contrib/jenkins.sh</span><br><span>+++ b/contrib/jenkins.sh</span><br><span>@@ -12,7 +12,7 @@</span><br><span> osmo-clean-workspace.sh</span><br><span> </span><br><span> autoreconf -fi</span><br><span style="color: hsl(0, 100%, 40%);">-./configure</span><br><span style="color: hsl(120, 100%, 40%);">+./configure --enable-asciidoc-warnings-check</span><br><span> $MAKE $PARALLEL_MAKE</span><br><span> $MAKE $PARALLEL_MAKE check</span><br><span> $MAKE $PARALLEL_MAKE distcheck</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15031">change 15031</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/15031"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-gsm-manuals </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iac993a0d1b17205397a1f1ef1a7bd3f9df739e36 </div>
<div style="display:none"> Gerrit-Change-Number: 15031 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>