<p>keith <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-msc/+/15009">View Change</a></p><div style="white-space:pre-wrap">Approvals:
fixeria: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Set coding in mncc_set_cause()<br><br>GSM 04.08 10.5.4.11<br><br>The Release indication needs to have the Coding Standard set.<br><br>For phones that would display a message on screen, such as<br>"Number not in use", if the coding standard is not defined,<br>the display may show "Error in Connection"<br><br>Change-Id: Ib28b62a41d433e231cff5910d19455296b284df6<br>---<br>M src/libmsc/mncc.c<br>M tests/msc_vlr/msc_vlr_test_call.c<br>M tests/msc_vlr/msc_vlr_test_call.err<br>3 files changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libmsc/mncc.c b/src/libmsc/mncc.c</span><br><span>index 8c95ecb..d0b2ff2 100644</span><br><span>--- a/src/libmsc/mncc.c</span><br><span>+++ b/src/libmsc/mncc.c</span><br><span>@@ -100,6 +100,7 @@</span><br><span> void mncc_set_cause(struct gsm_mncc *data, int loc, int val)</span><br><span> {</span><br><span> data->fields |= MNCC_F_CAUSE;</span><br><span style="color: hsl(120, 100%, 40%);">+ data->cause.coding = GSM48_CAUSE_CODING_GSM;</span><br><span> data->cause.location = loc;</span><br><span> data->cause.value = val;</span><br><span> }</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_call.c b/tests/msc_vlr/msc_vlr_test_call.c</span><br><span>index 6805f1a..065af25 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_call.c</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_call.c</span><br><span>@@ -401,7 +401,7 @@</span><br><span> * this only worked synchronously, i.e. only with internal MNCC. Instead of mimicking that, we need a proper</span><br><span> * async solution that also works with a PBX. */</span><br><span> cc_to_mncc_expect_tx("", MNCC_REL_CNF);</span><br><span style="color: hsl(0, 100%, 40%);">- dtap_expect_tx("032d080281af"); /* CC: Release */</span><br><span style="color: hsl(120, 100%, 40%);">+ dtap_expect_tx("032d0802e1af"); /* CC: Release */</span><br><span> expect_iu_release();</span><br><span> msc_a_release_cn(msub_msc_a(g_msub));</span><br><span> OSMO_ASSERT(dtap_tx_confirmed);</span><br><span>diff --git a/tests/msc_vlr/msc_vlr_test_call.err b/tests/msc_vlr/msc_vlr_test_call.err</span><br><span>index d5fd893..bbfa61b 100644</span><br><span>--- a/tests/msc_vlr/msc_vlr_test_call.err</span><br><span>+++ b/tests/msc_vlr/msc_vlr_test_call.err</span><br><span>@@ -1184,7 +1184,7 @@</span><br><span> DCC trans(CC IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) starting timer T308 with 10 seconds</span><br><span> DCC trans(CC IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) new state CALL_RECEIVED -> RELEASE_REQ</span><br><span> DMSC msc_a(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){MSC_A_ST_RELEASING}: RAN encode: DTAP on UTRAN-Iu</span><br><span style="color: hsl(0, 100%, 40%);">-- DTAP --UTRAN-Iu--> MS: GSM48_MT_CC_RELEASE: 032d080281af</span><br><span style="color: hsl(120, 100%, 40%);">+- DTAP --UTRAN-Iu--> MS: GSM48_MT_CC_RELEASE: 032d0802e1af</span><br><span> - DTAP matches expected message</span><br><span> DMSC dummy_msc_i(IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP){0}: Received Event MSC_I_EV_FROM_A_FORWARD_ACCESS_SIGNALLING_REQUEST</span><br><span> DMNCC trans(CC IMSI-901700000010650:MSISDN-42342:TMSI-0x03020100:UTRAN-Iu:PAGING_RESP callref-0x423 tid-0) tx MNCC_REL_CNF</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-msc/+/15009">change 15009</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-msc/+/15009"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-msc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib28b62a41d433e231cff5910d19455296b284df6 </div>
<div style="display:none"> Gerrit-Change-Number: 15009 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: keith <keith@rhizomatica.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>