<p>dexter has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/15007">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc_msc_data: remove unused member is_authenticated<br><br>The struct member struct bsc_msc_data->is_authenticated is set to true<br>permanently. This is a leftover from the sccplite implementation and can<br>be removed now.<br><br>Change-Id: I966a48b383c85345c92c9a1fec791150e96cd7b9<br>Related: OS#3112<br>---<br>M include/osmocom/bsc/bsc_msc_data.h<br>M src/osmo-bsc/gsm_08_08.c<br>M src/osmo-bsc/osmo_bsc_msc.c<br>3 files changed, 0 insertions(+), 10 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/07/15007/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/bsc_msc_data.h b/include/osmocom/bsc/bsc_msc_data.h</span><br><span>index 2ad7c68..5612483 100644</span><br><span>--- a/include/osmocom/bsc/bsc_msc_data.h</span><br><span>+++ b/include/osmocom/bsc/bsc_msc_data.h</span><br><span>@@ -77,7 +77,6 @@</span><br><span>    int core_lac;</span><br><span>        int core_ci;</span><br><span>         int rtp_base;</span><br><span style="color: hsl(0, 100%, 40%);">-   bool is_authenticated;</span><br><span> </span><br><span>   /* audio codecs */</span><br><span>   struct gsm48_multi_rate_conf amr_conf;</span><br><span>diff --git a/src/osmo-bsc/gsm_08_08.c b/src/osmo-bsc/gsm_08_08.c</span><br><span>index 6ca5455..4dc4883 100644</span><br><span>--- a/src/osmo-bsc/gsm_08_08.c</span><br><span>+++ b/src/osmo-bsc/gsm_08_08.c</span><br><span>@@ -307,8 +307,6 @@</span><br><span> </span><br><span> round_robin:</span><br><span>        llist_for_each_entry(msc, &bsc->mscs, entry) {</span><br><span style="color: hsl(0, 100%, 40%);">-           if (!msc->is_authenticated)</span><br><span style="color: hsl(0, 100%, 40%);">-                  continue;</span><br><span>            if (!is_emerg && msc->type != MSC_CON_TYPE_NORMAL)</span><br><span>                        continue;</span><br><span>            if (is_emerg && !msc->allow_emerg)</span><br><span>diff --git a/src/osmo-bsc/osmo_bsc_msc.c b/src/osmo-bsc/osmo_bsc_msc.c</span><br><span>index 7e78d94..24c8c6d 100644</span><br><span>--- a/src/osmo-bsc/osmo_bsc_msc.c</span><br><span>+++ b/src/osmo-bsc/osmo_bsc_msc.c</span><br><span>@@ -49,13 +49,6 @@</span><br><span>  uint16_t mgw_port;</span><br><span>   int rc;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     /* FIXME: This is a leftover from the old architecture that used</span><br><span style="color: hsl(0, 100%, 40%);">-         * sccp-lite with osmocom specific authentication. Since we now</span><br><span style="color: hsl(0, 100%, 40%);">-  * changed to AoIP the connected status and the authentication</span><br><span style="color: hsl(0, 100%, 40%);">-   * status is managed differently. However osmo_bsc_filter.c still</span><br><span style="color: hsl(0, 100%, 40%);">-        * needs the flags to be set to one. See also: OS#3112 */</span><br><span style="color: hsl(0, 100%, 40%);">-       msc->is_authenticated = 1;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>        if (net->mgw.conf->remote_port >= 0)</span><br><span>                mgw_port = net->mgw.conf->remote_port;</span><br><span>         else</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/15007">change 15007</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/15007"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I966a48b383c85345c92c9a1fec791150e96cd7b9 </div>
<div style="display:none"> Gerrit-Change-Number: 15007 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: dexter <pmaier@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>