<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/14988">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">usrp1: don't check for non-null underrun pointer<br><br>The pointer can't never be null, so avoid checking it.<br><br>Change-Id: I12e14641713a6494bc89570f02cecfc6f8fd4b5e<br>---<br>M Transceiver52M/device/usrp1/USRPDevice.cpp<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/88/14988/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/device/usrp1/USRPDevice.cpp b/Transceiver52M/device/usrp1/USRPDevice.cpp</span><br><span>index af0b3de..63debee 100644</span><br><span>--- a/Transceiver52M/device/usrp1/USRPDevice.cpp</span><br><span>+++ b/Transceiver52M/device/usrp1/USRPDevice.cpp</span><br><span>@@ -377,7 +377,7 @@</span><br><span>     return len;</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  if (underrun) *underrun = false;</span><br><span style="color: hsl(120, 100%, 40%);">+  *underrun = false;</span><br><span> </span><br><span>   uint32_t readBuf[2000];</span><br><span> </span><br><span>@@ -427,7 +427,7 @@</span><br><span>         continue;</span><br><span>       }</span><br><span>       if ((word0 >> 28) & 0x04) {</span><br><span style="color: hsl(0, 100%, 40%);">-     if (underrun) *underrun = true;</span><br><span style="color: hsl(120, 100%, 40%);">+       *underrun = true;</span><br><span>    LOGC(DDEV, DEBUG) << "UNDERRUN in TRX->USRP interface";</span><br><span>       }</span><br><span>       if (RSSI) *RSSI = (word0 >> 21) & 0x3f;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/14988">change 14988</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/14988"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I12e14641713a6494bc89570f02cecfc6f8fd4b5e </div>
<div style="display:none"> Gerrit-Change-Number: 14988 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>