<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/14979">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm0808_test: Fix wrong use of memcp<br><br>After recent system upgrade, gcc 9.1.0, I started getting gsm0808_test<br>failing locally:<br>Assert failed memcmp(&enc_ct, &dec_ct, sizeof(enc_ct)) == 0 libosmocore/tests/gsm0808/gsm0808_test.c:992<br><br>During investigation with gdb, fields of both structures seem to contain<br>same values. However, closer lookup gives some hints on why it fails:<br>(gdb) print memcmp(&enc_ct, &dec_ct, sizeof(enc_ct))<br>$1 = 85<br>(gdb) print memcmp(&enc_ct, &dec_ct, 12)<br>$14 = 85<br>(gdb) print ((uint8_t*)&enc_ct)[11]<br>$15 = 85 'U'<br>(gdb) print ((uint8_t*)&dec_ct)[11]<br>$16 = 0 '\000'<br><br>So the 12th byte in struct gsm0808_channel_type is basically an<br>alignment padding byte added by the compiler (to align perm_spch_len to<br>4-byte alignment). Since both compared structs are initialized without<br>memset(0) but using compiler's designated initializers, it seems the compiler<br>decided it's no longer needed to zero the padding byte, making memcp fail in<br>this case.<br><br>In order to avoid the failure, let's properly check every field instead<br>of using memcp here.<br><br>Change-Id: I17fe7a0a5dc650f050bba1f47d071be749550729<br>---<br>M tests/gsm0808/gsm0808_test.c<br>1 file changed, 4 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/79/14979/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/tests/gsm0808/gsm0808_test.c b/tests/gsm0808/gsm0808_test.c</span><br><span>index 8f1e299..2389218 100644</span><br><span>--- a/tests/gsm0808/gsm0808_test.c</span><br><span>+++ b/tests/gsm0808/gsm0808_test.c</span><br><span>@@ -989,7 +989,10 @@</span><br><span> </span><br><span>      rc_dec = gsm0808_dec_channel_type(&dec_ct, msg->data + 2, msg->len - 2);</span><br><span>   OSMO_ASSERT(rc_dec == 4);</span><br><span style="color: hsl(0, 100%, 40%);">-       OSMO_ASSERT(memcmp(&enc_ct, &dec_ct, sizeof(enc_ct)) == 0);</span><br><span style="color: hsl(120, 100%, 40%);">+   OSMO_ASSERT(enc_ct.ch_indctr == dec_ct.ch_indctr);</span><br><span style="color: hsl(120, 100%, 40%);">+    OSMO_ASSERT(enc_ct.ch_rate_type == dec_ct.ch_rate_type);</span><br><span style="color: hsl(120, 100%, 40%);">+      OSMO_ASSERT(enc_ct.perm_spch_len == dec_ct.perm_spch_len);</span><br><span style="color: hsl(120, 100%, 40%);">+    OSMO_ASSERT(memcmp(&enc_ct.perm_spch[0], &dec_ct.perm_spch[0], enc_ct.perm_spch_len) == 0);</span><br><span> </span><br><span>      msgb_free(msg);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/14979">change 14979</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/14979"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I17fe7a0a5dc650f050bba1f47d071be749550729 </div>
<div style="display:none"> Gerrit-Change-Number: 14979 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>