<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/14975">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty/vty.c: the command buffer can be accessed directly<br><br>Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39<br>---<br>M src/vty/vty.c<br>1 file changed, 8 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/75/14975/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/vty.c b/src/vty/vty.c</span><br><span>index 4960aea..85c9fe5 100644</span><br><span>--- a/src/vty/vty.c</span><br><span>+++ b/src/vty/vty.c</span><br><span>@@ -139,7 +139,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Authentication of vty */</span><br><span style="color: hsl(0, 100%, 40%);">-static void vty_auth(struct vty *vty, char *buf)</span><br><span style="color: hsl(120, 100%, 40%);">+static void vty_auth(struct vty *vty)</span><br><span> {</span><br><span>    char *passwd = NULL;</span><br><span>         enum node_type next_node = 0;</span><br><span>@@ -173,10 +173,10 @@</span><br><span>        if (passwd) {</span><br><span> #ifdef VTY_CRYPT_PW</span><br><span>                 if (host.encrypt)</span><br><span style="color: hsl(0, 100%, 40%);">-                       fail = strcmp(crypt(buf, passwd), passwd);</span><br><span style="color: hsl(120, 100%, 40%);">+                    fail = strcmp(crypt(vty->buf, passwd), passwd);</span><br><span>           else</span><br><span> #endif</span><br><span style="color: hsl(0, 100%, 40%);">-                  fail = strcmp(buf, passwd);</span><br><span style="color: hsl(120, 100%, 40%);">+                   fail = strcmp(vty->buf, passwd);</span><br><span>  } else</span><br><span>               fail = 1;</span><br><span> </span><br><span>@@ -420,7 +420,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Command execution over the vty interface. */</span><br><span style="color: hsl(0, 100%, 40%);">-static int vty_command(struct vty *vty, char *buf)</span><br><span style="color: hsl(120, 100%, 40%);">+static int vty_command(struct vty *vty)</span><br><span> {</span><br><span>      int ret;</span><br><span>     vector vline;</span><br><span>@@ -433,11 +433,11 @@</span><br><span>                                                   rem_port, sizeof(rem_port),</span><br><span>                                                  false);</span><br><span>           LOGP(DLGLOBAL, LOGL_DEBUG, "(%s:%s) Got VTY command: '%s'\n",</span><br><span style="color: hsl(0, 100%, 40%);">-              rem_addr, rem_port, buf);</span><br><span style="color: hsl(120, 100%, 40%);">+                     rem_addr, rem_port, vty->buf);</span><br><span>       }</span><br><span> </span><br><span>        /* Split readline string up into the vector */</span><br><span style="color: hsl(0, 100%, 40%);">-  vline = cmd_make_strvec(buf);</span><br><span style="color: hsl(120, 100%, 40%);">+ vline = cmd_make_strvec(vty->buf);</span><br><span> </span><br><span>    if (vline == NULL)</span><br><span>           return CMD_SUCCESS;</span><br><span>@@ -706,10 +706,10 @@</span><br><span>  switch (vty->node) {</span><br><span>      case AUTH_NODE:</span><br><span>      case AUTH_ENABLE_NODE:</span><br><span style="color: hsl(0, 100%, 40%);">-          vty_auth(vty, vty->buf);</span><br><span style="color: hsl(120, 100%, 40%);">+           vty_auth(vty);</span><br><span>               break;</span><br><span>       default:</span><br><span style="color: hsl(0, 100%, 40%);">-                ret = vty_command(vty, vty->buf);</span><br><span style="color: hsl(120, 100%, 40%);">+          ret = vty_command(vty);</span><br><span>              if (vty->type == VTY_TERM)</span><br><span>                        vty_hist_add(vty);</span><br><span>           break;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/14975">change 14975</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/14975"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic6d7d68e9a559a6fb5bd6eaf6eccceae51e7ed39 </div>
<div style="display:none"> Gerrit-Change-Number: 14975 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>