<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/14972">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">vty/telnet_interface.c: log connection accept() / close() events<br><br>Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c<br>---<br>M src/vty/telnet_interface.c<br>1 file changed, 13 insertions(+), 0 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/72/14972/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/vty/telnet_interface.c b/src/vty/telnet_interface.c</span><br><span>index d44754c..dbbbfec 100644</span><br><span>--- a/src/vty/telnet_interface.c</span><br><span>+++ b/src/vty/telnet_interface.c</span><br><span>@@ -123,6 +123,16 @@</span><br><span> int telnet_close_client(struct osmo_fd *fd)</span><br><span> {</span><br><span>       struct telnet_connection *conn = (struct telnet_connection*)fd->data;</span><br><span style="color: hsl(120, 100%, 40%);">+      struct sockaddr_in sockaddr;</span><br><span style="color: hsl(120, 100%, 40%);">+  socklen_t len = sizeof(sockaddr);</span><br><span style="color: hsl(120, 100%, 40%);">+     int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+     /* FIXME: getsockname() always fails: "Bad file descriptor" */</span><br><span style="color: hsl(120, 100%, 40%);">+      rc = getsockname(fd->fd, (struct sockaddr *) &sockaddr, &len);</span><br><span style="color: hsl(120, 100%, 40%);">+     if (rc == 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                LOGP(DLGLOBAL, LOGL_INFO, "Closing telnet connection %s:%u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+                   inet_ntoa(sockaddr.sin_addr), ntohs(sockaddr.sin_port));</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> </span><br><span>        close(fd->fd);</span><br><span>    osmo_fd_unregister(fd);</span><br><span>@@ -173,6 +183,9 @@</span><br><span>                return new_connection;</span><br><span>       }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+ LOGP(DLGLOBAL, LOGL_INFO, "Accept()ed new telnet connection from %s:%u\n",</span><br><span style="color: hsl(120, 100%, 40%);">+       inet_ntoa(sockaddr.sin_addr), ntohs(sockaddr.sin_port));</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span>      connection = talloc_zero(tall_telnet_ctx, struct telnet_connection);</span><br><span>         connection->priv = fd->data;</span><br><span>   connection->fd.data = connection;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/14972">change 14972</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/14972"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I77b31abfa159d2f269deaa5a08d94b7bbba7d23c </div>
<div style="display:none"> Gerrit-Change-Number: 14972 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>