<p>osmith <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-hlr/+/14933">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Jenkins Builder: Verified
pespin: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">db_auc.c: verify hex key sizes read from DB<br><br>Replace commented out size check for Ki with a real check, and use it<br>consistently for Ki, K, OP and OPC. Add a test that sets all keys to the<br>wrong size and tries to read them.<br><br>Related: OS#2565<br>Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696<br>---<br>M src/db_auc.c<br>M tests/db/db_test.c<br>M tests/db/db_test.err<br>3 files changed, 201 insertions(+), 29 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/db_auc.c b/src/db_auc.c</span><br><span>index e29b44b..2cf7143 100644</span><br><span>--- a/src/db_auc.c</span><br><span>+++ b/src/db_auc.c</span><br><span>@@ -73,6 +73,32 @@</span><br><span> return ret;</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* hexparse a specific column of a sqlite prepared statement into dst (with length check)</span><br><span style="color: hsl(120, 100%, 40%);">+ * returns 0 for success, -EIO on error */</span><br><span style="color: hsl(120, 100%, 40%);">+static int hexparse_stmt(uint8_t *dst, size_t dst_len, sqlite3_stmt *stmt, int col, const char *col_name,</span><br><span style="color: hsl(120, 100%, 40%);">+ const char *imsi)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ const uint8_t *text;</span><br><span style="color: hsl(120, 100%, 40%);">+ size_t col_len;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Bytes are stored as hex strings in database, hence divide length by two */</span><br><span style="color: hsl(120, 100%, 40%);">+ col_len = sqlite3_column_bytes(stmt, col) / 2;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ if (col_len != dst_len) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGAUC(imsi, LOGL_ERROR, "Error reading %s, expected length %lu but has length %lu\n", col_name,</span><br><span style="color: hsl(120, 100%, 40%);">+ dst_len, col_len);</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EIO;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ text = sqlite3_column_text(stmt, col);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!text) {</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGAUC(imsi, LOGL_ERROR, "Error reading %s\n", col_name);</span><br><span style="color: hsl(120, 100%, 40%);">+ return -EIO;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_hexparse((void *)text, dst, dst_len);</span><br><span style="color: hsl(120, 100%, 40%);">+ return 0;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* obtain the authentication data for a given imsi</span><br><span> * returns 0 for success, negative value on error:</span><br><span> * -ENOENT if the IMSI is not known, -ENOKEY if the IMSI is known but has no auth data,</span><br><span>@@ -113,49 +139,34 @@</span><br><span> /* obtain result values using sqlite3_column_*() */</span><br><span> if (sqlite3_column_type(stmt, 1) == SQLITE_INTEGER) {</span><br><span> /* we do have some 2G authentication data */</span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t *ki;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- aud2g->algo = sqlite3_column_int(stmt, 1);</span><br><span style="color: hsl(0, 100%, 40%);">- ki = sqlite3_column_text(stmt, 2);</span><br><span style="color: hsl(0, 100%, 40%);">-#if 0</span><br><span style="color: hsl(0, 100%, 40%);">- if (sqlite3_column_bytes(stmt, 2) != sizeof(aud2g->u.gsm.ki)) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGAUC(imsi, LOGL_ERROR, "Error reading Ki: %d\n", rc);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (hexparse_stmt(aud2g->u.gsm.ki, sizeof(aud2g->u.gsm.ki), stmt, 2, "Ki", imsi))</span><br><span> goto end_2g;</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(0, 100%, 40%);">-#endif</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_hexparse((void*)ki, (void*)&aud2g->u.gsm.ki, sizeof(aud2g->u.gsm.ki));</span><br><span style="color: hsl(120, 100%, 40%);">+ aud2g->algo = sqlite3_column_int(stmt, 1);</span><br><span> aud2g->type = OSMO_AUTH_TYPE_GSM;</span><br><span> } else</span><br><span> LOGAUC(imsi, LOGL_DEBUG, "No 2G Auth Data\n");</span><br><span style="color: hsl(0, 100%, 40%);">-//end_2g:</span><br><span style="color: hsl(120, 100%, 40%);">+end_2g:</span><br><span> if (sqlite3_column_type(stmt, 3) == SQLITE_INTEGER) {</span><br><span> /* we do have some 3G authentication data */</span><br><span style="color: hsl(0, 100%, 40%);">- const uint8_t *k, *op, *opc;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- aud3g->algo = sqlite3_column_int(stmt, 3);</span><br><span style="color: hsl(0, 100%, 40%);">- k = sqlite3_column_text(stmt, 4);</span><br><span style="color: hsl(0, 100%, 40%);">- if (!k) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGAUC(imsi, LOGL_ERROR, "Error reading K: %d\n", rc);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (hexparse_stmt(aud3g->u.umts.k, sizeof(aud3g->u.umts.k), stmt, 4, "K", imsi)) {</span><br><span> ret = -EIO;</span><br><span> goto out;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_hexparse((void*)k, (void*)&aud3g->u.umts.k, sizeof(aud3g->u.umts.k));</span><br><span style="color: hsl(120, 100%, 40%);">+ aud3g->algo = sqlite3_column_int(stmt, 3);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> /* UMTS Subscribers can have either OP or OPC */</span><br><span style="color: hsl(0, 100%, 40%);">- op = sqlite3_column_text(stmt, 5);</span><br><span style="color: hsl(0, 100%, 40%);">- if (!op) {</span><br><span style="color: hsl(0, 100%, 40%);">- opc = sqlite3_column_text(stmt, 6);</span><br><span style="color: hsl(0, 100%, 40%);">- if (!opc) {</span><br><span style="color: hsl(0, 100%, 40%);">- LOGAUC(imsi, LOGL_ERROR, "Error reading OPC: %d\n", rc);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (sqlite3_column_text(stmt, 5)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (hexparse_stmt(aud3g->u.umts.opc, sizeof(aud3g->u.umts.opc), stmt, 5, "OP", imsi)) {</span><br><span> ret = -EIO;</span><br><span> goto out;</span><br><span> }</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_hexparse((void*)opc, (void*)&aud3g->u.umts.opc,</span><br><span style="color: hsl(0, 100%, 40%);">- sizeof(aud3g->u.umts.opc));</span><br><span style="color: hsl(0, 100%, 40%);">- aud3g->u.umts.opc_is_op = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- } else {</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_hexparse((void*)op, (void*)&aud3g->u.umts.opc,</span><br><span style="color: hsl(0, 100%, 40%);">- sizeof(aud3g->u.umts.opc));</span><br><span> aud3g->u.umts.opc_is_op = 1;</span><br><span style="color: hsl(120, 100%, 40%);">+ } else {</span><br><span style="color: hsl(120, 100%, 40%);">+ if (hexparse_stmt(aud3g->u.umts.opc, sizeof(aud3g->u.umts.opc), stmt, 6, "OPC", imsi)) {</span><br><span style="color: hsl(120, 100%, 40%);">+ ret = -EIO;</span><br><span style="color: hsl(120, 100%, 40%);">+ goto out;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ aud3g->u.umts.opc_is_op = 0;</span><br><span> }</span><br><span> aud3g->u.umts.sqn = sqlite3_column_int64(stmt, 7);</span><br><span> aud3g->u.umts.ind_bitlen = sqlite3_column_int(stmt, 8);</span><br><span>diff --git a/tests/db/db_test.c b/tests/db/db_test.c</span><br><span>index fdd62c5..cc299bf 100644</span><br><span>--- a/tests/db/db_test.c</span><br><span>+++ b/tests/db/db_test.c</span><br><span>@@ -208,6 +208,17 @@</span><br><span> #undef Phex</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+void db_raw_sql(struct db_context *dbc, const char *sql)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ sqlite3_stmt *stmt;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ fprintf(stderr, "raw SQL: %s\n", sql);</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_RC(sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL), SQLITE_OK);</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_RC(sqlite3_step(stmt), SQLITE_DONE);</span><br><span style="color: hsl(120, 100%, 40%);">+ db_remove_reset(stmt);</span><br><span style="color: hsl(120, 100%, 40%);">+ sqlite3_finalize(stmt);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static const char *imsi0 = "123456789000000";</span><br><span> static const char *imsi1 = "123456789000001";</span><br><span> static const char *imsi2 = "123456789000002";</span><br><span>@@ -749,6 +760,70 @@</span><br><span> comment_end();</span><br><span> }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+/* Make each key too short in this test. Note that we can't set them longer than the allowed size without changing the</span><br><span style="color: hsl(120, 100%, 40%);">+ * table structure. */</span><br><span style="color: hsl(120, 100%, 40%);">+static void test_subscr_aud_invalid_len()</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ int64_t id;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ comment_start();</span><br><span style="color: hsl(120, 100%, 40%);">+ comment("Create subscriber");</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_RC(db_subscr_create(dbc, imsi0, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS), 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_SEL(imsi, imsi0, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ id = g_subscr.id;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Invalid Ki length */</span><br><span style="color: hsl(120, 100%, 40%);">+ comment("Set auth data, 2G only, with invalid Ki length");</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_RC(db_subscr_update_aud_by_id(dbc, id,</span><br><span style="color: hsl(120, 100%, 40%);">+ mk_aud_2g(OSMO_AUTH_ALG_COMP128v1, "0123456789abcdef0123456789abcdef")),</span><br><span style="color: hsl(120, 100%, 40%);">+ 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Use raw SQL to avoid length check in db_subscr_update_aud_by_id(). This changes all rows in the table, which</span><br><span style="color: hsl(120, 100%, 40%);">+ * is fine for this test (implicit WHERE 1). */</span><br><span style="color: hsl(120, 100%, 40%);">+ db_raw_sql(dbc, "UPDATE auc_2g SET ki = '0123456789abcdef0123456789abcde'");</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_SEL_AUD(imsi0, -ENOKEY, id);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ comment("Remove 2G auth data");</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_RC(db_subscr_update_aud_by_id(dbc, id,</span><br><span style="color: hsl(120, 100%, 40%);">+ mk_aud_2g(OSMO_AUTH_ALG_NONE, NULL)),</span><br><span style="color: hsl(120, 100%, 40%);">+ 0);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Invalid K length */</span><br><span style="color: hsl(120, 100%, 40%);">+ comment("Set auth data, 3G only, with invalid K length");</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_RC(db_subscr_update_aud_by_id(dbc, id,</span><br><span style="color: hsl(120, 100%, 40%);">+ mk_aud_3g(OSMO_AUTH_ALG_MILENAGE,</span><br><span style="color: hsl(120, 100%, 40%);">+ "BeefedCafeFaceAcedAddedDecadeFee", true,</span><br><span style="color: hsl(120, 100%, 40%);">+ "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)),</span><br><span style="color: hsl(120, 100%, 40%);">+ 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ db_raw_sql(dbc, "UPDATE auc_3g SET k = 'C01ffedC1cadaeAc1d1f1edAcac1aB0'");</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_SEL_AUD(imsi0, -EIO, id);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Invalid OP length */</span><br><span style="color: hsl(120, 100%, 40%);">+ comment("Set auth data, 3G only, with invalid OP length");</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_RC(db_subscr_update_aud_by_id(dbc, id,</span><br><span style="color: hsl(120, 100%, 40%);">+ mk_aud_3g(OSMO_AUTH_ALG_MILENAGE,</span><br><span style="color: hsl(120, 100%, 40%);">+ "BeefedCafeFaceAcedAddedDecadeFee", true,</span><br><span style="color: hsl(120, 100%, 40%);">+ "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)),</span><br><span style="color: hsl(120, 100%, 40%);">+ 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ db_raw_sql(dbc, "UPDATE auc_3g SET op = 'BeefedCafeFaceAcedAddedDecadeFe'");</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_SEL_AUD(imsi0, -EIO, id);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* Invalid OPC length */</span><br><span style="color: hsl(120, 100%, 40%);">+ comment("Set auth data, 3G only, with invalid OPC length");</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_RC(db_subscr_update_aud_by_id(dbc, id,</span><br><span style="color: hsl(120, 100%, 40%);">+ mk_aud_3g(OSMO_AUTH_ALG_MILENAGE,</span><br><span style="color: hsl(120, 100%, 40%);">+ "BeefedCafeFaceAcedAddedDecadeFee", false,</span><br><span style="color: hsl(120, 100%, 40%);">+ "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)),</span><br><span style="color: hsl(120, 100%, 40%);">+ 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ db_raw_sql(dbc, "UPDATE auc_3g SET opc = 'BeefedCafeFaceAcedAddedDecadeFe'");</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_SEL_AUD(imsi0, -EIO, id);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ comment("Delete subscriber");</span><br><span style="color: hsl(120, 100%, 40%);">+ ASSERT_RC(db_subscr_delete_by_id(dbc, id), 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ comment_end();</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> static void test_subscr_sqn()</span><br><span> {</span><br><span> int64_t id;</span><br><span>@@ -900,6 +975,7 @@</span><br><span> </span><br><span> test_subscr_create_update_sel_delete();</span><br><span> test_subscr_aud();</span><br><span style="color: hsl(120, 100%, 40%);">+ test_subscr_aud_invalid_len();</span><br><span> test_subscr_sqn();</span><br><span> </span><br><span> printf("Done\n");</span><br><span>diff --git a/tests/db/db_test.err b/tests/db/db_test.err</span><br><span>index 4dc77e8..a7c4cf1 100644</span><br><span>--- a/tests/db/db_test.err</span><br><span>+++ b/tests/db/db_test.err</span><br><span>@@ -1338,6 +1338,91 @@</span><br><span> ===== test_subscr_aud: SUCCESS</span><br><span> </span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+===== test_subscr_aud_invalid_len</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+--- Create subscriber</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+db_subscr_create(dbc, imsi0, DB_SUBSCR_FLAG_NAM_CS | DB_SUBSCR_FLAG_NAM_PS) --> 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+db_subscr_get_by_imsi(dbc, imsi0, &g_subscr) --> 0</span><br><span style="color: hsl(120, 100%, 40%);">+struct hlr_subscriber {</span><br><span style="color: hsl(120, 100%, 40%);">+ .id = 1,</span><br><span style="color: hsl(120, 100%, 40%);">+ .imsi = '123456789000000',</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+--- Set auth data, 2G only, with invalid Ki length</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+db_subscr_update_aud_by_id(dbc, id, mk_aud_2g(OSMO_AUTH_ALG_COMP128v1, "0123456789abcdef0123456789abcdef")) --> 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+raw SQL: UPDATE auc_2g SET ki = '0123456789abcdef0123456789abcde'</span><br><span style="color: hsl(120, 100%, 40%);">+sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL) --> SQLITE_OK</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+sqlite3_step(stmt) --> SQLITE_DONE</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -126</span><br><span style="color: hsl(120, 100%, 40%);">+DAUC IMSI='123456789000000': Error reading Ki, expected length 16 but has length 15</span><br><span style="color: hsl(120, 100%, 40%);">+DAUC IMSI='123456789000000': No 3G Auth Data</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+--- Remove 2G auth data</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+db_subscr_update_aud_by_id(dbc, id, mk_aud_2g(OSMO_AUTH_ALG_NONE, NULL)) --> 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+--- Set auth data, 3G only, with invalid K length</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+db_subscr_update_aud_by_id(dbc, id, mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, "BeefedCafeFaceAcedAddedDecadeFee", true, "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)) --> 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+raw SQL: UPDATE auc_3g SET k = 'C01ffedC1cadaeAc1d1f1edAcac1aB0'</span><br><span style="color: hsl(120, 100%, 40%);">+sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL) --> SQLITE_OK</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+sqlite3_step(stmt) --> SQLITE_DONE</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -5</span><br><span style="color: hsl(120, 100%, 40%);">+DAUC IMSI='123456789000000': No 2G Auth Data</span><br><span style="color: hsl(120, 100%, 40%);">+DAUC IMSI='123456789000000': Error reading K, expected length 16 but has length 15</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+--- Set auth data, 3G only, with invalid OP length</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+db_subscr_update_aud_by_id(dbc, id, mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, "BeefedCafeFaceAcedAddedDecadeFee", true, "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)) --> 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+raw SQL: UPDATE auc_3g SET op = 'BeefedCafeFaceAcedAddedDecadeFe'</span><br><span style="color: hsl(120, 100%, 40%);">+sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL) --> SQLITE_OK</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+sqlite3_step(stmt) --> SQLITE_DONE</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -5</span><br><span style="color: hsl(120, 100%, 40%);">+DAUC IMSI='123456789000000': No 2G Auth Data</span><br><span style="color: hsl(120, 100%, 40%);">+DAUC IMSI='123456789000000': Error reading OP, expected length 16 but has length 15</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+--- Set auth data, 3G only, with invalid OPC length</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+db_subscr_update_aud_by_id(dbc, id, mk_aud_3g(OSMO_AUTH_ALG_MILENAGE, "BeefedCafeFaceAcedAddedDecadeFee", false, "C01ffedC1cadaeAc1d1f1edAcac1aB0a", 5)) --> 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+raw SQL: UPDATE auc_3g SET opc = 'BeefedCafeFaceAcedAddedDecadeFe'</span><br><span style="color: hsl(120, 100%, 40%);">+sqlite3_prepare_v2(dbc->db, sql, -1, &stmt, NULL) --> SQLITE_OK</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+sqlite3_step(stmt) --> SQLITE_DONE</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+db_get_auth_data(dbc, imsi0, &g_aud2g, &g_aud3g, &g_id) --> -5</span><br><span style="color: hsl(120, 100%, 40%);">+DAUC IMSI='123456789000000': No 2G Auth Data</span><br><span style="color: hsl(120, 100%, 40%);">+DAUC IMSI='123456789000000': Error reading OPC, expected length 16 but has length 15</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+--- Delete subscriber</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+db_subscr_delete_by_id(dbc, id) --> 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+===== test_subscr_aud_invalid_len: SUCCESS</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> ===== test_subscr_sqn</span><br><span> </span><br><span> --- Set SQN for unknown subscriber</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-hlr/+/14933">change 14933</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-hlr/+/14933"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-hlr </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ib8e8e9394fb65c6e7932ce9f8bebc321b99f7696 </div>
<div style="display:none"> Gerrit-Change-Number: 14933 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>