<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-remsim/+/14929">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">rspro_client_fsm: Fix another memory leak<br><br>We basically must ensure that all code paths *except* the path leading<br>to rspro_dec_msg() must call msgb_free(msg).  This was not the case<br>in two situations, as fixed now.<br><br>Change-Id: I29f8413bb43b3ebf827be0bceda1a4db1e6e2b7c<br>---<br>M src/rspro_client_fsm.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/rspro_client_fsm.c b/src/rspro_client_fsm.c</span><br><span>index 06364da..d487f32 100644</span><br><span>--- a/src/rspro_client_fsm.c</span><br><span>+++ b/src/rspro_client_fsm.c</span><br><span>@@ -121,8 +121,10 @@</span><br><span>      switch (hh->proto) {</span><br><span>      case IPAC_PROTO_IPACCESS:</span><br><span>            rc = ipaccess_bts_handle_ccm(srvc->conn, &srvc->ipa_dev, msg);</span><br><span style="color: hsl(0, 100%, 40%);">-                if (rc < 0)</span><br><span style="color: hsl(120, 100%, 40%);">+                if (rc < 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+                      msgb_free(msg);</span><br><span>                      break;</span><br><span style="color: hsl(120, 100%, 40%);">+                }</span><br><span>            switch (hh->data[0]) {</span><br><span>            case IPAC_MSGT_PONG:</span><br><span>                         ipa_keepalive_fsm_pong_received(srvc->keepalive_fi);</span><br><span>@@ -130,8 +132,8 @@</span><br><span>                        break;</span><br><span>               default:</span><br><span>                     break;</span><br><span style="color: hsl(0, 100%, 40%);">-          msgb_free(msg);</span><br><span>              }</span><br><span style="color: hsl(120, 100%, 40%);">+             msgb_free(msg);</span><br><span>              break;</span><br><span>       case IPAC_PROTO_OSMO:</span><br><span>                if (!he || msgb_l2len(msg) < sizeof(*he))</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-remsim/+/14929">change 14929</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-remsim/+/14929"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-remsim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I29f8413bb43b3ebf827be0bceda1a4db1e6e2b7c </div>
<div style="display:none"> Gerrit-Change-Number: 14929 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>