<p><a href="https://gerrit.osmocom.org/c/osmo-ci/+/14894">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/14894/1/scripts/common.sh">File scripts/common.sh:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14894/1/scripts/common.sh@96">Patch Set #1, Line 96:</a> <code style="font-family:monospace,monospace">      if ! git clone "$@"; then</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I think you should not use "" here.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">"$@" must be quoted in order to pass the parameters without change. Here's an example:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> #!/bin/sh<br> <br> in_quotes() {<br>         echo "in quotes:"<br>         for i in "$@"; do<br>                 echo "arg: $i"<br>         done<br> }<br> <br> not_in_quotes() {<br>         echo "not in quotes:"<br>         for i in $@; do<br>                 echo "arg: $i"<br>         done<br> }<br> <br> in_quotes "a b" c d<br> not_in_quotes "a b" c d</pre><p style="white-space: pre-wrap; word-wrap: break-word;"><br>This yields:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> in quotes:<br> arg: a b<br> arg: c<br> arg: d<br> not in quotes:<br> arg: a<br> arg: b<br> arg: c<br> arg: d</pre><p style="white-space: pre-wrap; word-wrap: break-word;">See also: https://www.tldp.org/LDP/abs/html/internalvariables.html</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ci/+/14894">change 14894</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ci/+/14894"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ci </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic9a6d3f0c2b8dad2661ede793c21307f1680a52e </div>
<div style="display:none"> Gerrit-Change-Number: 14894 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-CC: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 23 Jul 2019 06:21:26 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>