<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/14849">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">osmocon: Fix out-of-bounds for partial reads in un_tool_read()<br><br>"uint8_t buf[4096]; ... &buf + 1" renders an offset of 4096, and not 1!<br><br>Change-Id: Ie1407371fe949c3d5746b9fdc32ececc9443692b<br>Closes: CID#198580<br>---<br>M src/host/osmocon/osmocon.c<br>1 file changed, 2 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/osmocon/osmocon.c b/src/host/osmocon/osmocon.c</span><br><span>index 26416f7..9090d27 100644</span><br><span>--- a/src/host/osmocon/osmocon.c</span><br><span>+++ b/src/host/osmocon/osmocon.c</span><br><span>@@ -1242,7 +1242,7 @@</span><br><span> </span><br><span>    c = 0;</span><br><span>       while(c < 2) {</span><br><span style="color: hsl(0, 100%, 40%);">-               rc = read(fd->fd, &buf + c, 2 - c);</span><br><span style="color: hsl(120, 100%, 40%);">+            rc = read(fd->fd, buf + c, 2 - c);</span><br><span>                if(rc == 0) {</span><br><span>                        // disconnect</span><br><span>                        goto close;</span><br><span>@@ -1262,7 +1262,7 @@</span><br><span> </span><br><span>      c = 0;</span><br><span>       while(c < length) {</span><br><span style="color: hsl(0, 100%, 40%);">-          rc = read(fd->fd, &buf + c, length - c);</span><br><span style="color: hsl(120, 100%, 40%);">+               rc = read(fd->fd, buf + c, length - c);</span><br><span>           if(rc == 0) {</span><br><span>                        // disconnect</span><br><span>                        goto close;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/14849">change 14849</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/14849"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ie1407371fe949c3d5746b9fdc32ececc9443692b </div>
<div style="display:none"> Gerrit-Change-Number: 14849 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>