<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #d4ffd4;">Code-Review +2</span></p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/14853">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/14853/1/src/host/layer23/src/mobile/gsm480_ss.c">File src/host/layer23/src/mobile/gsm480_ss.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14853/1/src/host/layer23/src/mobile/gsm480_ss.c@404">Patch Set #1, Line 404:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">tlv[2] = 0x80 | cause;<br>                tlv[3] = 0x80 | GSM48_CAUSE_LOC_USER;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">An idea for another change: cause should actually go after location. Please see section 10.5.4.11, and https://git.osmocom.org/osmo-msc/tree/src/libmsc/gsm_04_80.c#n88.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/14853">change 14853</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/14853"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iba2ace7d82be5677d28b25f60ab0312fed76f5e5 </div>
<div style="display:none"> Gerrit-Change-Number: 14853 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Sun, 21 Jul 2019 08:48:46 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>