<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/14878">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">sgsnemu: Fix format string argument count<br><br>Change-Id: I6bb8c3df53a585913d5e0351ecad2e6ae9f0b886<br>Closes: CID#178643<br>---<br>M sgsnemu/sgsnemu.c<br>1 file changed, 8 insertions(+), 4 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ggsn refs/changes/78/14878/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/sgsnemu/sgsnemu.c b/sgsnemu/sgsnemu.c</span><br><span>index 36b52fc..8e41031 100644</span><br><span>--- a/sgsnemu/sgsnemu.c</span><br><span>+++ b/sgsnemu/sgsnemu.c</span><br><span>@@ -1452,12 +1452,16 @@</span><br><span>             if (!accept_ra || !forwarding)</span><br><span>                       printf("Could not open proc file for %s ?!?\n", tun->devname);</span><br><span>          else {</span><br><span style="color: hsl(0, 100%, 40%);">-                  if (!strcmp(accept_ra, "0") ||</span><br><span style="color: hsl(0, 100%, 40%);">-                            (!strcmp(forwarding, "1") && !strcmp(accept_ra, "1"))) {</span><br><span style="color: hsl(0, 100%, 40%);">-                                printf("%s is %s, i.e. your tun device is not configured to accept "</span><br><span style="color: hsl(0, 100%, 40%);">-                                  "router advertisements; SLAAC will not suceed, please "</span><br><span style="color: hsl(120, 100%, 40%);">+                     if (!strcmp(accept_ra, "0")) {</span><br><span style="color: hsl(120, 100%, 40%);">+                              printf("accept_ra=0, i.e. your tun device is not configured to accept "</span><br><span style="color: hsl(120, 100%, 40%);">+                                     "router advertisements; SLAAC will not succeed, please "</span><br><span>                                   "fix your setup!\n");</span><br><span>                      }</span><br><span style="color: hsl(120, 100%, 40%);">+                     if (!strcmp(forwarding, "1") && !strcmp(accept_ra, "1")) {</span><br><span style="color: hsl(120, 100%, 40%);">+                                printf("forwarding=1 and accept_ra=1, i.e. your tun device is not "</span><br><span style="color: hsl(120, 100%, 40%);">+                                 "configured to accept router advertisements; SLAAC will not "</span><br><span style="color: hsl(120, 100%, 40%);">+                                       "succeed, please fix your setup!\n");</span><br><span style="color: hsl(120, 100%, 40%);">+                       }</span><br><span>            }</span><br><span>            free(accept_ra);</span><br><span>             free(forwarding);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ggsn/+/14878">change 14878</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ggsn/+/14878"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ggsn </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6bb8c3df53a585913d5e0351ecad2e6ae9f0b886 </div>
<div style="display:none"> Gerrit-Change-Number: 14878 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>