<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-remsim/+/14884">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  laforge: Looks good to me, approved
  Jenkins Builder: Verified

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">server: rest_api: Fix memory leak in slotmap post<br><br>We need to decrement the refcount on the json_req object.<br><br>Change-Id: I1a550eff76e6a72013ab47ef8f240a72d7a7d9cb<br>---<br>M src/server/rest_api.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/server/rest_api.c b/src/server/rest_api.c</span><br><span>index 969f672..abd46b9 100644</span><br><span>--- a/src/server/rest_api.c</span><br><span>+++ b/src/server/rest_api.c</span><br><span>@@ -309,7 +309,7 @@</span><br><span>         struct slot_mapping slotmap, *map;</span><br><span>   struct rspro_client_conn *conn;</span><br><span>      json_error_t json_err;</span><br><span style="color: hsl(0, 100%, 40%);">-  json_t *json_req;</span><br><span style="color: hsl(120, 100%, 40%);">+     json_t *json_req = NULL;</span><br><span>     int rc;</span><br><span> </span><br><span>  json_req = ulfius_get_json_body_request(req, &json_err);</span><br><span>@@ -341,10 +341,12 @@</span><br><span>         pthread_rwlock_unlock(&srv->rwlock);</span><br><span> </span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+   json_decref(json_req);</span><br><span>       ulfius_set_empty_body_response(resp, 201);</span><br><span> </span><br><span>       return U_CALLBACK_COMPLETE;</span><br><span> err:</span><br><span style="color: hsl(120, 100%, 40%);">+   json_decref(json_req);</span><br><span>       ulfius_set_empty_body_response(resp, 400);</span><br><span>   return U_CALLBACK_COMPLETE;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-remsim/+/14884">change 14884</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-remsim/+/14884"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-remsim </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1a550eff76e6a72013ab47ef8f240a72d7a7d9cb </div>
<div style="display:none"> Gerrit-Change-Number: 14884 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>