<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14870">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">ipaccess.c: Avoid calling close(-1) on error path<br><br>Change-Id: Idabb9805a4a10c95ba0e01bc3f80ed8db87a9f85<br>Closes: CID#157118<br>---<br>M src/input/ipaccess.c<br>1 file changed, 4 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmo-abis refs/changes/70/14870/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/input/ipaccess.c b/src/input/ipaccess.c</span><br><span>index 136aa79..0d6d55d 100644</span><br><span>--- a/src/input/ipaccess.c</span><br><span>+++ b/src/input/ipaccess.c</span><br><span>@@ -215,8 +215,10 @@</span><br><span>   return 0;</span><br><span> err:</span><br><span>    osmo_fd_unregister(bfd);</span><br><span style="color: hsl(0, 100%, 40%);">-        close(bfd->fd);</span><br><span style="color: hsl(0, 100%, 40%);">-      bfd->fd = -1;</span><br><span style="color: hsl(120, 100%, 40%);">+      if (bfd->fd != -1) {</span><br><span style="color: hsl(120, 100%, 40%);">+               close(bfd->fd);</span><br><span style="color: hsl(120, 100%, 40%);">+            bfd->fd = -1;</span><br><span style="color: hsl(120, 100%, 40%);">+      }</span><br><span>    e1inp_line_put(line);</span><br><span>        return -1;</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmo-abis/+/14870">change 14870</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmo-abis/+/14870"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmo-abis </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Idabb9805a4a10c95ba0e01bc3f80ed8db87a9f85 </div>
<div style="display:none"> Gerrit-Change-Number: 14870 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>