<p>laforge has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmocom-bb/+/14851">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">gsm322: Fix resource leak in gsm322_init() while reading BA<br><br>Change-Id: Id42102ab8581e247f495fb7e05dc62a6743d28c5<br>Closes: CID#198546<br>---<br>M src/host/layer23/src/mobile/gsm322.c<br>1 file changed, 3 insertions(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmocom-bb refs/changes/51/14851/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/host/layer23/src/mobile/gsm322.c b/src/host/layer23/src/mobile/gsm322.c</span><br><span>index cfd70d8..56dd236 100644</span><br><span>--- a/src/host/layer23/src/mobile/gsm322.c</span><br><span>+++ b/src/host/layer23/src/mobile/gsm322.c</span><br><span>@@ -5085,8 +5085,10 @@</span><br><span>            } else</span><br><span>               while(!feof(fp)) {</span><br><span>                   ba = talloc_zero(ms, struct gsm322_ba_list);</span><br><span style="color: hsl(0, 100%, 40%);">-                    if (!ba)</span><br><span style="color: hsl(120, 100%, 40%);">+                      if (!ba) {</span><br><span style="color: hsl(120, 100%, 40%);">+                            fclose(fp);</span><br><span>                          return -ENOMEM;</span><br><span style="color: hsl(120, 100%, 40%);">+                       }</span><br><span>                    rc = fread(buf, 4, 1, fp);</span><br><span>                   if (!rc) {</span><br><span>                           talloc_free(ba);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmocom-bb/+/14851">change 14851</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmocom-bb/+/14851"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmocom-bb </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Id42102ab8581e247f495fb7e05dc62a6743d28c5 </div>
<div style="display:none"> Gerrit-Change-Number: 14851 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>