<p>pespin <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/14646">View Change</a></p><div style="white-space:pre-wrap">Approvals:
laforge: Looks good to me, but someone else must approve
fixeria: Looks good to me, but someone else must approve
pespin: Looks good to me, approved
Jenkins Builder: Verified
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Transceiver: Move out TRXD socket send code to prepare for TRXDv1<br><br>Only old v0 is supported so far. TRXD protocol related data/logic is<br>moved to its own file out of Transceiver class. Code is refactored so it<br>can be re-used later by TRXDv1.<br><br>Related: OS#4006<br>Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed<br>---<br>M Transceiver52M/Makefile.am<br>M Transceiver52M/Transceiver.cpp<br>M Transceiver52M/Transceiver.h<br>A Transceiver52M/proto_trxd.c<br>M Transceiver52M/proto_trxd.h<br>5 files changed, 128 insertions(+), 54 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/Makefile.am b/Transceiver52M/Makefile.am</span><br><span>index 4adf474..791c586 100644</span><br><span>--- a/Transceiver52M/Makefile.am</span><br><span>+++ b/Transceiver52M/Makefile.am</span><br><span>@@ -47,7 +47,8 @@</span><br><span> Transceiver.cpp \</span><br><span> ChannelizerBase.cpp \</span><br><span> Channelizer.cpp \</span><br><span style="color: hsl(0, 100%, 40%);">- Synthesis.cpp</span><br><span style="color: hsl(120, 100%, 40%);">+ Synthesis.cpp \</span><br><span style="color: hsl(120, 100%, 40%);">+ proto_trxd.c</span><br><span> </span><br><span> libtransceiver_common_la_SOURCES = \</span><br><span> $(COMMON_SOURCES) \</span><br><span>diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp</span><br><span>index 5c5707b..6bbf3a3 100644</span><br><span>--- a/Transceiver52M/Transceiver.cpp</span><br><span>+++ b/Transceiver52M/Transceiver.cpp</span><br><span>@@ -31,7 +31,7 @@</span><br><span> #include "osmo_signal.h"</span><br><span> #include "proto_trxd.h"</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#include <osmocom/core/bits.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/utils.h></span><br><span> #include <osmocom/core/socket.h></span><br><span> }</span><br><span> </span><br><span>@@ -125,7 +125,7 @@</span><br><span> rssiOffset(wRssiOffset), stackSize(wStackSize),</span><br><span> mSPSTx(tx_sps), mSPSRx(rx_sps), mChans(chans), mEdge(false), mOn(false), mForceClockInterface(false),</span><br><span> mTxFreq(0.0), mRxFreq(0.0), mTSC(0), mMaxExpectedDelayAB(0), mMaxExpectedDelayNB(0),</span><br><span style="color: hsl(0, 100%, 40%);">- mWriteBurstToDiskMask(0)</span><br><span style="color: hsl(120, 100%, 40%);">+ mWriteBurstToDiskMask(0), mVersionTRXD(0)</span><br><span> {</span><br><span> txFullScale = mRadioInterface->fullScaleInputValue();</span><br><span> rxFullScale = mRadioInterface->fullScaleOutputValue();</span><br><span>@@ -971,36 +971,20 @@</span><br><span> </span><br><span> void Transceiver::driveReceiveFIFO(size_t chan)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">- int msgLen;</span><br><span style="color: hsl(0, 100%, 40%);">- int TOAint; // in 1/256 symbols</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> struct trx_ul_burst_ind bi;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- if (!pullRadioVector(chan, &bi) || bi.idle)</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!pullRadioVector(chan, &bi))</span><br><span> return;</span><br><span style="color: hsl(120, 100%, 40%);">+ if (!bi.idle)</span><br><span style="color: hsl(120, 100%, 40%);">+ logRxBurst(chan, &bi);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">- logRxBurst(chan, &bi);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- TOAint = (int) (bi.toa * 256.0 + 0.5); // round to closest integer</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- char burstString[sizeof(struct trxd_hdr_v0) + bi.nbits + 2];</span><br><span style="color: hsl(0, 100%, 40%);">- struct trxd_hdr_v0* pkt = (struct trxd_hdr_v0*)burstString;</span><br><span style="color: hsl(0, 100%, 40%);">- pkt->common.version = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- pkt->common.reserved = 0;</span><br><span style="color: hsl(0, 100%, 40%);">- pkt->common.tn = bi.tn;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_store32be(bi.fn, &pkt->common.fn);</span><br><span style="color: hsl(0, 100%, 40%);">- pkt->v0.rssi = bi.rssi;</span><br><span style="color: hsl(0, 100%, 40%);">- osmo_store16be(TOAint, &pkt->v0.toa);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- for (unsigned i = 0; i < bi.nbits; i++)</span><br><span style="color: hsl(0, 100%, 40%);">- pkt->soft_bits[i] = (char) round(bi.rx_burst[i] * 255.0);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi.nbits] */</span><br><span style="color: hsl(0, 100%, 40%);">- pkt->soft_bits[bi.nbits + 1] = '\0';</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">- msgLen = write(mDataSockets[chan], burstString, sizeof(struct trxd_hdr_v0) + bi.nbits + 2);</span><br><span style="color: hsl(0, 100%, 40%);">- if (msgLen <= 0)</span><br><span style="color: hsl(0, 100%, 40%);">- LOGCHAN(chan, DTRXCTRL, WARNING) << "mDataSockets write(" << mCtrlSockets[chan] << ") failed: " << msgLen;</span><br><span style="color: hsl(120, 100%, 40%);">+ switch (mVersionTRXD) {</span><br><span style="color: hsl(120, 100%, 40%);">+ case 0:</span><br><span style="color: hsl(120, 100%, 40%);">+ trxd_send_burst_ind_v0(chan, mDataSockets[chan], &bi);</span><br><span style="color: hsl(120, 100%, 40%);">+ break;</span><br><span style="color: hsl(120, 100%, 40%);">+ default:</span><br><span style="color: hsl(120, 100%, 40%);">+ OSMO_ASSERT(false);</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span> }</span><br><span> </span><br><span> void Transceiver::driveTxFIFO()</span><br><span>diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h</span><br><span>index a66c962..aa2a716 100644</span><br><span>--- a/Transceiver52M/Transceiver.h</span><br><span>+++ b/Transceiver52M/Transceiver.h</span><br><span>@@ -34,19 +34,6 @@</span><br><span> #include "config_defs.h"</span><br><span> }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-#define MAX_RX_BURST_BUF_SIZE EDGE_BURST_NBITS</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-struct trx_ul_burst_ind {</span><br><span style="color: hsl(0, 100%, 40%);">- float rx_burst[MAX_RX_BURST_BUF_SIZE]; /* soft bits normalized 0..1 */</span><br><span style="color: hsl(0, 100%, 40%);">- unsigned nbits; // number of symbols per slot in rxBurst, not counting guard periods</span><br><span style="color: hsl(0, 100%, 40%);">- uint32_t fn; // TDMA frame number</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t tn; // TDMA time-slot number</span><br><span style="color: hsl(0, 100%, 40%);">- double rssi; // in dBFS</span><br><span style="color: hsl(0, 100%, 40%);">- double toa; // in symbols</span><br><span style="color: hsl(0, 100%, 40%);">- double noise; // noise level in dBFS</span><br><span style="color: hsl(0, 100%, 40%);">- bool idle; // true if no valid burst is included</span><br><span style="color: hsl(0, 100%, 40%);">-};</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span> class Transceiver;</span><br><span> </span><br><span> /** Channel descriptor for transceiver object and channel number pair */</span><br><span>@@ -229,6 +216,7 @@</span><br><span> unsigned mMaxExpectedDelayAB; ///< maximum expected time-of-arrival offset in GSM symbols for Access Bursts (RACH)</span><br><span> unsigned mMaxExpectedDelayNB; ///< maximum expected time-of-arrival offset in GSM symbols for Normal Bursts</span><br><span> unsigned mWriteBurstToDiskMask; ///< debug: bitmask to indicate which timeslots to dump to disk</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned mVersionTRXD; ///< Format version to use for TRXD protocol communication</span><br><span> </span><br><span> std::vector<TransceiverState> mStates;</span><br><span> </span><br><span>diff --git a/Transceiver52M/proto_trxd.c b/Transceiver52M/proto_trxd.c</span><br><span>new file mode 100644</span><br><span>index 0000000..5cf22e6</span><br><span>--- /dev/null</span><br><span>+++ b/Transceiver52M/proto_trxd.c</span><br><span>@@ -0,0 +1,77 @@</span><br><span style="color: hsl(120, 100%, 40%);">+/*</span><br><span style="color: hsl(120, 100%, 40%);">+ * Copyright (C) 2019 sysmocom - s.f.m.c. GmbH</span><br><span style="color: hsl(120, 100%, 40%);">+ * All Rights Reserved</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * SPDX-License-Identifier: AGPL-3.0+</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * Author: Pau Espin Pedrol <pespin@sysmocom.de></span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is free software: you can redistribute it and/or modify</span><br><span style="color: hsl(120, 100%, 40%);">+ * it under the terms of the GNU Affero General Public License as published by</span><br><span style="color: hsl(120, 100%, 40%);">+ * the Free Software Foundation, either version 3 of the License, or</span><br><span style="color: hsl(120, 100%, 40%);">+ * (at your option) any later version.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * This program is distributed in the hope that it will be useful,</span><br><span style="color: hsl(120, 100%, 40%);">+ * but WITHOUT ANY WARRANTY; without even the implied warranty of</span><br><span style="color: hsl(120, 100%, 40%);">+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the</span><br><span style="color: hsl(120, 100%, 40%);">+ * GNU Affero General Public License for more details.</span><br><span style="color: hsl(120, 100%, 40%);">+ *</span><br><span style="color: hsl(120, 100%, 40%);">+ * You should have received a copy of the GNU Affero General Public License</span><br><span style="color: hsl(120, 100%, 40%);">+ * along with this program. If not, see <http://www.gnu.org/licenses/>.</span><br><span style="color: hsl(120, 100%, 40%);">+ * See the COPYING file in the main directory for details.</span><br><span style="color: hsl(120, 100%, 40%);">+ */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include "proto_trxd.h"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#include <osmocom/core/bits.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void trxd_fill_common(struct trxd_hdr_common *common, const struct trx_ul_burst_ind *bi, uint8_t version)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ common->version = version && 0x07;</span><br><span style="color: hsl(120, 100%, 40%);">+ common->reserved = 0;</span><br><span style="color: hsl(120, 100%, 40%);">+ common->tn = bi->tn;</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_store32be(bi->fn, &common->fn);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void trxd_fill_v0_specific(struct trxd_hdr_v0_specific *v0, const struct trx_ul_burst_ind *bi)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ int toa_int;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* in 1/256 symbols, round to closest integer */</span><br><span style="color: hsl(120, 100%, 40%);">+ toa_int = (int) (bi->toa * 256.0 + 0.5);</span><br><span style="color: hsl(120, 100%, 40%);">+ v0->rssi = bi->rssi;</span><br><span style="color: hsl(120, 100%, 40%);">+ osmo_store16be(toa_int, &v0->toa);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+static void trxd_fill_burst_normalized255(uint8_t* soft_bits, const struct trx_ul_burst_ind *bi)</span><br><span style="color: hsl(120, 100%, 40%);">+{</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned i;</span><br><span style="color: hsl(120, 100%, 40%);">+ for (i = 0; i < bi->nbits; i++)</span><br><span style="color: hsl(120, 100%, 40%);">+ soft_bits[i] = (char) round(bi->rx_burst[i] * 255.0);</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+bool trxd_send_burst_ind_v0(size_t chan, int fd, const struct trx_ul_burst_ind *bi) {</span><br><span style="color: hsl(120, 100%, 40%);">+ int rc;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* v0 doesn't support idle frames, they are simply dropped, not sent */</span><br><span style="color: hsl(120, 100%, 40%);">+ if(bi->idle)</span><br><span style="color: hsl(120, 100%, 40%);">+ return true;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* +2: Historically (OpenBTS times), two extra non-used bytes are sent appeneded to each burst */</span><br><span style="color: hsl(120, 100%, 40%);">+ char buf[sizeof(struct trxd_hdr_v0) + bi->nbits + 2];</span><br><span style="color: hsl(120, 100%, 40%);">+ struct trxd_hdr_v0* pkt = (struct trxd_hdr_v0*)buf;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ trxd_fill_common(&pkt->common, bi, 0);</span><br><span style="color: hsl(120, 100%, 40%);">+ trxd_fill_v0_specific(&pkt->v0, bi);</span><br><span style="color: hsl(120, 100%, 40%);">+ trxd_fill_burst_normalized255(&pkt->soft_bits[0], bi);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi->nbits] */</span><br><span style="color: hsl(120, 100%, 40%);">+ pkt->soft_bits[bi->nbits + 1] = '\0';</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+ rc = write(fd, buf, sizeof(struct trxd_hdr_v0) + bi->nbits + 2);</span><br><span style="color: hsl(120, 100%, 40%);">+ if (rc <= 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+ CLOGCHAN(chan, DMAIN, LOGL_NOTICE, "mDataSockets write(%d) failed: %d\n", fd, rc);</span><br><span style="color: hsl(120, 100%, 40%);">+ return false;</span><br><span style="color: hsl(120, 100%, 40%);">+ }</span><br><span style="color: hsl(120, 100%, 40%);">+ return true;</span><br><span style="color: hsl(120, 100%, 40%);">+}</span><br><span>diff --git a/Transceiver52M/proto_trxd.h b/Transceiver52M/proto_trxd.h</span><br><span>index 9da18db..2e5ad52 100644</span><br><span>--- a/Transceiver52M/proto_trxd.h</span><br><span>+++ b/Transceiver52M/proto_trxd.h</span><br><span>@@ -1,28 +1,52 @@</span><br><span> #pragma once</span><br><span> </span><br><span> #include <stdint.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <stdbool.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <unistd.h></span><br><span style="color: hsl(120, 100%, 40%);">+#include <math.h></span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> #include <osmocom/core/endian.h></span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+#include "debug.h"</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+#define MAX_RX_BURST_BUF_SIZE 444 /* 444 = EDGE_BURST_NBITS */</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+struct trx_ul_burst_ind {</span><br><span style="color: hsl(120, 100%, 40%);">+ float rx_burst[MAX_RX_BURST_BUF_SIZE]; /* soft bits normalized 0..1 */</span><br><span style="color: hsl(120, 100%, 40%);">+ unsigned nbits; // number of symbols per slot in rxBurst, not counting guard periods</span><br><span style="color: hsl(120, 100%, 40%);">+ uint32_t fn; // TDMA frame number</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t tn; // TDMA time-slot number</span><br><span style="color: hsl(120, 100%, 40%);">+ double rssi; // in dBFS</span><br><span style="color: hsl(120, 100%, 40%);">+ double toa; // in symbols</span><br><span style="color: hsl(120, 100%, 40%);">+ double noise; // noise level in dBFS</span><br><span style="color: hsl(120, 100%, 40%);">+ bool idle; // true if no valid burst is included</span><br><span style="color: hsl(120, 100%, 40%);">+};</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+bool trxd_send_burst_ind_v0(size_t chan, int fd, const struct trx_ul_burst_ind *bi);</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+/* The latest supported TRXD header format version */</span><br><span style="color: hsl(120, 100%, 40%);">+#define TRX_DATA_FORMAT_VER 0</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span> struct trxd_hdr_common {</span><br><span> #if OSMO_IS_LITTLE_ENDIAN</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t tn:3,</span><br><span style="color: hsl(0, 100%, 40%);">- reserved:1,</span><br><span style="color: hsl(0, 100%, 40%);">- version:4;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t tn:3,</span><br><span style="color: hsl(120, 100%, 40%);">+ reserved:1,</span><br><span style="color: hsl(120, 100%, 40%);">+ version:4;</span><br><span> #elif OSMO_IS_BIG_ENDIAN</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t version:4,</span><br><span style="color: hsl(0, 100%, 40%);">- reserved:1,</span><br><span style="color: hsl(0, 100%, 40%);">- tn:3;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t version:4,</span><br><span style="color: hsl(120, 100%, 40%);">+ reserved:1,</span><br><span style="color: hsl(120, 100%, 40%);">+ tn:3;</span><br><span> #endif</span><br><span style="color: hsl(0, 100%, 40%);">- uint32_t fn; /* big endian */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint32_t fn; /* big endian */</span><br><span> } __attribute__ ((packed));</span><br><span> </span><br><span> struct trxd_hdr_v0_specific {</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t rssi;</span><br><span style="color: hsl(0, 100%, 40%);">- uint16_t toa; /* big endian */</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t rssi;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint16_t toa; /* big endian */</span><br><span> } __attribute__ ((packed));</span><br><span> </span><br><span> struct trxd_hdr_v0 {</span><br><span style="color: hsl(0, 100%, 40%);">- struct trxd_hdr_common common;</span><br><span style="color: hsl(0, 100%, 40%);">- struct trxd_hdr_v0_specific v0;</span><br><span style="color: hsl(0, 100%, 40%);">- uint8_t soft_bits[0];</span><br><span style="color: hsl(120, 100%, 40%);">+ struct trxd_hdr_common common;</span><br><span style="color: hsl(120, 100%, 40%);">+ struct trxd_hdr_v0_specific v0;</span><br><span style="color: hsl(120, 100%, 40%);">+ uint8_t soft_bits[0];</span><br><span> } __attribute__ ((packed));</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/14646">change 14646</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/14646"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I5786dd44b076202c6f1a6e82405670e8605797ed </div>
<div style="display:none"> Gerrit-Change-Number: 14646 </div>
<div style="display:none"> Gerrit-PatchSet: 10 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>