<p>fixeria has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/libosmocore/+/14825">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bitvec/bitval2mask(): cosmetic: get rid of temporary int variable<br><br>Change-Id: I9d6f6b66c99c43107d1ad3e80af332e967bb19e8<br>---<br>M src/bitvec.c<br>1 file changed, 4 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/25/14825/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/bitvec.c b/src/bitvec.c</span><br><span>index dac0401..0c263ad 100644</span><br><span>--- a/src/bitvec.c</span><br><span>+++ b/src/bitvec.c</span><br><span>@@ -58,25 +58,18 @@</span><br><span> /* convert ZERO/ONE/L/H to a bitmask at given pos in a byte */</span><br><span> static uint8_t bitval2mask(enum bit_value bit, uint8_t bitnum)</span><br><span> {</span><br><span style="color: hsl(0, 100%, 40%);">-   int bitval;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>  switch (bit) {</span><br><span>       case ZERO:</span><br><span style="color: hsl(0, 100%, 40%);">-              bitval = (0 << bitnum);</span><br><span style="color: hsl(0, 100%, 40%);">-           break;</span><br><span style="color: hsl(120, 100%, 40%);">+                return (0 << bitnum);</span><br><span>  case ONE:</span><br><span style="color: hsl(0, 100%, 40%);">-               bitval = (1 << bitnum);</span><br><span style="color: hsl(0, 100%, 40%);">-           break;</span><br><span style="color: hsl(120, 100%, 40%);">+                return (1 << bitnum);</span><br><span>  case L:</span><br><span style="color: hsl(0, 100%, 40%);">-         bitval = ((0x2b ^ (0 << bitnum)) & (1 << bitnum));</span><br><span style="color: hsl(0, 100%, 40%);">-              break;</span><br><span style="color: hsl(120, 100%, 40%);">+                return ((0x2b ^ (0 << bitnum)) & (1 << bitnum));</span><br><span>     case H:</span><br><span style="color: hsl(0, 100%, 40%);">-         bitval = ((0x2b ^ (1 << bitnum)) & (1 << bitnum));</span><br><span style="color: hsl(0, 100%, 40%);">-              break;</span><br><span style="color: hsl(120, 100%, 40%);">+                return ((0x2b ^ (1 << bitnum)) & (1 << bitnum));</span><br><span>     default:</span><br><span>             return 0;</span><br><span>    }</span><br><span style="color: hsl(0, 100%, 40%);">-       return bitval;</span><br><span> }</span><br><span> </span><br><span> /*! check if the bit is 0 or 1 for a given position inside a bitvec</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/libosmocore/+/14825">change 14825</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/libosmocore/+/14825"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: libosmocore </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I9d6f6b66c99c43107d1ad3e80af332e967bb19e8 </div>
<div style="display:none"> Gerrit-Change-Number: 14825 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>