<p>laforge <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bsc/+/14766">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">comment and VTY doc tweaks<br><br>Clarify some in-code comments.<br><br>Fix descriptions of some handover timers, which still talked of "MO" and "MT"<br>handover -- which we now call "inter-BSC out" or "inter-BSC in" instead.<br><br>Change-Id: I8429a830edd0325893ac90f22fcc05309617bd2d<br>---<br>M include/osmocom/bsc/gsm_data.h<br>M src/osmo-bsc/handover_fsm.c<br>M src/osmo-bsc/net_init.c<br>3 files changed, 6 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h</span><br><span>index a464001..d82d1ba 100644</span><br><span>--- a/include/osmocom/bsc/gsm_data.h</span><br><span>+++ b/include/osmocom/bsc/gsm_data.h</span><br><span>@@ -1505,7 +1505,7 @@</span><br><span>     struct llist_head bts_list;</span><br><span>  struct llist_head bts_rejected;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-     /* shall reference gsm_network_T[] */</span><br><span style="color: hsl(120, 100%, 40%);">+ /* see gsm_network_T_defs */</span><br><span>         struct osmo_tdef *T_defs;</span><br><span> </span><br><span>        enum gsm_chan_t ctype_by_chreq[_NUM_CHREQ_T];</span><br><span>diff --git a/src/osmo-bsc/handover_fsm.c b/src/osmo-bsc/handover_fsm.c</span><br><span>index 22618c5..7406a97 100644</span><br><span>--- a/src/osmo-bsc/handover_fsm.c</span><br><span>+++ b/src/osmo-bsc/handover_fsm.c</span><br><span>@@ -200,7 +200,8 @@</span><br><span>         conn = req->old_lchan->conn;</span><br><span>   OSMO_ASSERT(conn && conn->fi);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   /* To make sure we're allowed to start a handover, go through a gscon event dispatch. */</span><br><span style="color: hsl(120, 100%, 40%);">+  /* To make sure we're allowed to start a handover, go through a gscon event dispatch. If that is accepted, the</span><br><span style="color: hsl(120, 100%, 40%);">+     * same req is passed to handover_start(). */</span><br><span>        osmo_fsm_inst_dispatch(conn->fi, GSCON_EV_HANDOVER_START, req);</span><br><span> }</span><br><span> </span><br><span>diff --git a/src/osmo-bsc/net_init.c b/src/osmo-bsc/net_init.c</span><br><span>index 1ef9bd5..34403fa 100644</span><br><span>--- a/src/osmo-bsc/net_init.c</span><br><span>+++ b/src/osmo-bsc/net_init.c</span><br><span>@@ -26,10 +26,10 @@</span><br><span> #include <osmocom/bsc/neighbor_ident.h></span><br><span> </span><br><span> static struct osmo_tdef gsm_network_T_defs[] = {</span><br><span style="color: hsl(0, 100%, 40%);">-     { .T=7, .default_val=10, .desc="inter-BSC Handover MO, HO Required to HO Command" },</span><br><span style="color: hsl(0, 100%, 40%);">-  { .T=8, .default_val=10, .desc="inter-BSC Handover MO, HO Command to final Clear" },</span><br><span style="color: hsl(120, 100%, 40%);">+        { .T=7, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP HO Required to HO Command timeout" },</span><br><span style="color: hsl(120, 100%, 40%);">+       { .T=8, .default_val=10, .desc="inter-BSC/MSC Handover outgoing, BSSMAP HO Command to final Clear timeout" },</span><br><span>      { .T=10, .default_val=6, .desc="RR Assignment" },</span><br><span style="color: hsl(0, 100%, 40%);">-     { .T=101, .default_val=10, .desc="inter-BSC Handover MT, HO Request to HO Accept" },</span><br><span style="color: hsl(120, 100%, 40%);">+        { .T=101, .default_val=10, .desc="inter-BSC/MSC Handover incoming, BSSMAP HO Request to HO Accept" },</span><br><span>      { .T=3101, .default_val=3, .desc="RR Immediate Assignment" },</span><br><span>      { .T=3103, .default_val=5, .desc="Handover" },</span><br><span>     { .T=3105, .default_val=100, .unit=OSMO_TDEF_MS, .desc="Physical Information" },</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bsc/+/14766">change 14766</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bsc/+/14766"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bsc </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I8429a830edd0325893ac90f22fcc05309617bd2d </div>
<div style="display:none"> Gerrit-Change-Number: 14766 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: neels <nhofmeyr@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>