<p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/14685">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c">File src/osmo-bts-trx/scheduler_trx.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14685/1/src/osmo-bts-trx/scheduler_trx.c@800">Patch Set #1, Line 800:</a> <code style="font-family:monospace,monospace">                      synch_seq = rach_get_synch_seq((sbit_t *) bi->burst, NULL);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Printing either C/I or the match rate conditionally would complicate the LOGL1S(... […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">What's more important - the simplicity of debugging or reducing the code by one line?</p><p style="white-space: pre-wrap; word-wrap: break-word;">I would appreciate if you return the printing. Don't reduce debugging functionality - only increase it.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/14685">change 14685</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/14685"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I1cb28a9d6c98993705b73937409276994f375dc0 </div>
<div style="display:none"> Gerrit-Change-Number: 14685 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 10 Jul 2019 18:13:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Vadim Yanitskiy <axilirator@gmail.com> </div>
<div style="display:none"> Comment-In-Reply-To: ipse <Alexander.Chemeris@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>