<p>lynxis lazus has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-pcu/+/14696">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Encoding: write_packet_ack_nack_desc_egprs: don't use a reference for rest_bits<br><br>The rest_bits are never read after calling this function nor are rest_bits<br>updated properly.<br><br>Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89<br>---<br>M src/encoding.cpp<br>1 file changed, 1 insertion(+), 1 deletion(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/96/14696/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/encoding.cpp b/src/encoding.cpp</span><br><span>index e868379..99c1018 100644</span><br><span>--- a/src/encoding.cpp</span><br><span>+++ b/src/encoding.cpp</span><br><span>@@ -830,7 +830,7 @@</span><br><span> </span><br><span> static void write_packet_ack_nack_desc_egprs(</span><br><span>         bitvec * dest, unsigned& wp,</span><br><span style="color: hsl(0, 100%, 40%);">-        gprs_rlc_ul_window *window, bool is_final, unsigned& rest_bits)</span><br><span style="color: hsl(120, 100%, 40%);">+   gprs_rlc_ul_window *window, bool is_final, unsigned rest_bits)</span><br><span> {</span><br><span>  unsigned int urbb_len = 0;</span><br><span>   uint8_t crbb_len = 0;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-pcu/+/14696">change 14696</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-pcu/+/14696"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-pcu </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic350b0365b125638a6c752f692bef981ad6b9d89 </div>
<div style="display:none"> Gerrit-Change-Number: 14696 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>