<p>pespin <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/14661">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Transceiver: Avoid noise calculation formula in 2 branches in pullRadioVector<br><br>Makes code easier to follow and will help in forthcoming refactoring<br>once idle frames are supported.<br><br>Change-Id: I56c84e9684ca460efd6c983d7e95d8e455bcac69<br>---<br>M Transceiver52M/Transceiver.cpp<br>1 file changed, 5 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp</span><br><span>index 58e8719..7f05a2c 100644</span><br><span>--- a/Transceiver52M/Transceiver.cpp</span><br><span>+++ b/Transceiver52M/Transceiver.cpp</span><br><span>@@ -631,19 +631,18 @@</span><br><span>   burst = radio_burst->getVector(max_i);</span><br><span>   avg = sqrt(avg / radio_burst->chans());</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  bi->rssi = 20.0 * log10(rxFullScale / avg) + rssiOffset;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>   if (type == IDLE) {</span><br><span>     /* Update noise levels */</span><br><span>     state->mNoises.insert(avg);</span><br><span>     state->mNoiseLev = state->mNoises.avg();</span><br><span style="color: hsl(0, 100%, 40%);">-    bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset;</span><br><span style="color: hsl(120, 100%, 40%);">+  }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  bi->rssi = 20.0 * log10(rxFullScale / avg) + rssiOffset;</span><br><span style="color: hsl(120, 100%, 40%);">+  bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset;</span><br><span style="color: hsl(120, 100%, 40%);">+</span><br><span style="color: hsl(120, 100%, 40%);">+  if (type == IDLE) {</span><br><span>     delete radio_burst;</span><br><span>     return false;</span><br><span style="color: hsl(0, 100%, 40%);">-  } else {</span><br><span style="color: hsl(0, 100%, 40%);">-    /* Do not update noise levels */</span><br><span style="color: hsl(0, 100%, 40%);">-    bi->noise = 20.0 * log10(rxFullScale / state->mNoiseLev) + rssiOffset;</span><br><span>   }</span><br><span> </span><br><span>   unsigned max_toa = (type == RACH || type == EXT_RACH) ?</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/14661">change 14661</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/14661"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I56c84e9684ca460efd6c983d7e95d8e455bcac69 </div>
<div style="display:none"> Gerrit-Change-Number: 14661 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>