<p>pespin <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/14663">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Jenkins Builder: Verified
  fixeria: Looks good to me, but someone else must approve
  laforge: Looks good to me, approved

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Transceiver: pullRadioVector(): Move initialization of var to start of function<br><br>This will be needed upon forthcoming refactor to support idle frames,<br>which will add a goto return. Otherwise compiler complains:<br><br>error: jump to label ret_idle [-fpermissive]<br>note:   crosses initialization of unsigned int max_toa<br><br>Change-Id: Icd2793adc7b73a795184639b95fb5da336909b59<br>---<br>M Transceiver52M/Transceiver.cpp<br>1 file changed, 3 insertions(+), 2 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp</span><br><span>index 81b428a..92d4061 100644</span><br><span>--- a/Transceiver52M/Transceiver.cpp</span><br><span>+++ b/Transceiver52M/Transceiver.cpp</span><br><span>@@ -577,6 +577,7 @@</span><br><span>   int rc;</span><br><span>   complex amp;</span><br><span>   float toa, max = -1.0, avg = 0.0;</span><br><span style="color: hsl(120, 100%, 40%);">+  unsigned max_toa;</span><br><span>   int max_i = -1;</span><br><span>   signalVector *burst;</span><br><span>   GSM::Time burstTime;</span><br><span>@@ -645,8 +646,8 @@</span><br><span>     return false;</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  unsigned max_toa = (type == RACH || type == EXT_RACH) ?</span><br><span style="color: hsl(0, 100%, 40%);">-                      mMaxExpectedDelayAB : mMaxExpectedDelayNB;</span><br><span style="color: hsl(120, 100%, 40%);">+  max_toa = (type == RACH || type == EXT_RACH) ?</span><br><span style="color: hsl(120, 100%, 40%);">+            mMaxExpectedDelayAB : mMaxExpectedDelayNB;</span><br><span> </span><br><span>   /* Detect normal or RACH bursts */</span><br><span>   rc = detectAnyBurst(*burst, mTSC, BURST_THRESH, mSPSRx, type, amp, toa, max_toa);</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/14663">change 14663</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/14663"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Icd2793adc7b73a795184639b95fb5da336909b59 </div>
<div style="display:none"> Gerrit-Change-Number: 14663 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>