<p style="white-space: pre-wrap; word-wrap: break-word;">This change is ready for review.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/14657">View Change</a></p><p>2 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/14657/5/Transceiver52M/proto_trxd.h">File Transceiver52M/proto_trxd.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14657/5/Transceiver52M/proto_trxd.h@17">Patch Set #5, Line 17:</a> <code style="font-family:monospace,monospace">Not supported yet</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Neither OsmoTRX will support them any time soon.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Sure, I just wanted to list them here since they are also described in the protocol header.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/14657/2/Transceiver52M/proto_trxd.c">File Transceiver52M/proto_trxd.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14657/2/Transceiver52M/proto_trxd.c@68">Patch Set #2, Line 68:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">pkt->common.version = 1;<br>        pkt->common.reserved = 0;<br>  pkt->common.tn = bi->tn;<br>        osmo_store32be(bi->fn, &pkt->common.fn);<br>    pkt->v1.rssi = bi->rssi;<br>        osmo_store16be(toa_int, &pkt->v1.toa);<br></pre></blockquote></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This basically duplicates what trxd_send_burst_ind_v0() does. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I don't think it's really a benefit moving it, since anyway one still needs to set version bit differently for instance.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/14657">change 14657</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/14657"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I53db2678458a7377c87875b58b58b76a1b900517 </div>
<div style="display:none"> Gerrit-Change-Number: 14657 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 04 Jul 2019 14:45:40 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>