<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/14662">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Transceiver: Simplify code on early error return when calling detectAnyBurst<br><br>We get rid of one branch and simplify code logic.<br><br>Change-Id: I026e35262bfe42c3d23ebdc06d84e4908a8380e2<br>---<br>M Transceiver52M/Transceiver.cpp<br>1 file changed, 4 insertions(+), 8 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/62/14662/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp</span><br><span>index 7f05a2c..81b428a 100644</span><br><span>--- a/Transceiver52M/Transceiver.cpp</span><br><span>+++ b/Transceiver52M/Transceiver.cpp</span><br><span>@@ -650,20 +650,16 @@</span><br><span> </span><br><span>   /* Detect normal or RACH bursts */</span><br><span>   rc = detectAnyBurst(*burst, mTSC, BURST_THRESH, mSPSRx, type, amp, toa, max_toa);</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span style="color: hsl(0, 100%, 40%);">-  if (rc > 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-    type = (CorrType) rc;</span><br><span style="color: hsl(0, 100%, 40%);">-  } else if (rc <= 0) {</span><br><span style="color: hsl(0, 100%, 40%);">-    if (rc == -SIGERR_CLIP) {</span><br><span style="color: hsl(120, 100%, 40%);">+  if (rc <= 0) {</span><br><span style="color: hsl(120, 100%, 40%);">+    if (rc == -SIGERR_CLIP)</span><br><span>       LOG(WARNING) << "Clipping detected on received RACH or Normal Burst";</span><br><span style="color: hsl(0, 100%, 40%);">-    } else if (rc != SIGERR_NONE) {</span><br><span style="color: hsl(120, 100%, 40%);">+    else if (rc != SIGERR_NONE)</span><br><span>       LOG(WARNING) << "Unhandled RACH or Normal Burst detection error";</span><br><span style="color: hsl(0, 100%, 40%);">-    }</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>     delete radio_burst;</span><br><span>     return false;</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(120, 100%, 40%);">+  type = (CorrType) rc;</span><br><span>   bi->toa = toa;</span><br><span>   rxBurst = demodAnyBurst(*burst, mSPSRx, amp, toa, type);</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/14662">change 14662</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/14662"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I026e35262bfe42c3d23ebdc06d84e4908a8380e2 </div>
<div style="display:none"> Gerrit-Change-Number: 14662 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>