<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/14639">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Transceiver: Drop unused rssi_valid struct field<br><br>That field is actually never used. Furthermore, if pullRadioVector()<br>returns false, then the caller should consider the 'trx_ul_burst_ind'<br>structure as uninitialized. Moreover, RSSI is mandatory - we cannot send<br>burst indications without it.<br><br>Related: OS#4006<br>Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82<br>---<br>M Transceiver52M/Transceiver.cpp<br>M Transceiver52M/Transceiver.h<br>2 files changed, 0 insertions(+), 5 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/39/14639/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp</span><br><span>index 716a507..4999ac4 100644</span><br><span>--- a/Transceiver52M/Transceiver.cpp</span><br><span>+++ b/Transceiver52M/Transceiver.cpp</span><br><span>@@ -559,7 +559,6 @@</span><br><span>   int max_i = -1;</span><br><span>   signalVector *burst;</span><br><span>   TransceiverState *state = &mStates[chan];</span><br><span style="color: hsl(0, 100%, 40%);">-  bi->rssi_valid = false;</span><br><span> </span><br><span>   /* Blocking FIFO read */</span><br><span>   radioVector *radio_burst = mReceiveFIFO[chan]->read();</span><br><span>@@ -609,9 +608,6 @@</span><br><span> </span><br><span>   bi->rssi = 20.0 * log10(rxFullScale / avg);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  /* RSSI estimation are valid */</span><br><span style="color: hsl(0, 100%, 40%);">-  bi->rssi_valid = true;</span><br><span style="color: hsl(0, 100%, 40%);">-</span><br><span>   if (type == IDLE) {</span><br><span>     /* Update noise levels */</span><br><span>     state->mNoises.insert(avg);</span><br><span>diff --git a/Transceiver52M/Transceiver.h b/Transceiver52M/Transceiver.h</span><br><span>index 0f452c1..965d07d 100644</span><br><span>--- a/Transceiver52M/Transceiver.h</span><br><span>+++ b/Transceiver52M/Transceiver.h</span><br><span>@@ -41,7 +41,6 @@</span><br><span>         double rssi; // in dBFS</span><br><span>         double toa;  // in symbols</span><br><span>         double noise; // noise level in dBFS</span><br><span style="color: hsl(0, 100%, 40%);">-        bool rssi_valid; // are RSSI, noise and burstTime valid</span><br><span> };</span><br><span> </span><br><span> class Transceiver;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/14639">change 14639</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/14639"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia109298aebe8ba4750a39338ba7962555903cd82 </div>
<div style="display:none"> Gerrit-Change-Number: 14639 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>