<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-trx/+/14632">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts<br><br>Those 2 bytes at the end have been sent over the TRXD socket for<br>historical reasons. However, osmo-bts-trx also supports receiving bursts<br>without that padding for quite a while now, so let's drop those two<br>(since anyway those are not going to be sent for sure in v1 of TRXD<br>protocol).<br><br>Related: OS#4006<br>Change-Id: Iedc54011f333f48c6c8b81cab4d640f7601e01dd<br>---<br>M Transceiver52M/Transceiver.cpp<br>1 file changed, 1 insertion(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/32/14632/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/Transceiver52M/Transceiver.cpp b/Transceiver52M/Transceiver.cpp</span><br><span>index c7e213a..ff768ac 100644</span><br><span>--- a/Transceiver52M/Transceiver.cpp</span><br><span>+++ b/Transceiver52M/Transceiver.cpp</span><br><span>@@ -952,11 +952,9 @@</span><br><span>   for (unsigned i = 0; i < bi.nbits; i++)</span><br><span>     pkt->soft_bits[i] = (char) round((*burstItr++) * 255.0);</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  /* +1: Historical reason. There's an uninitizalied byte in there: pkt->soft_bits[bi.nbits] */</span><br><span style="color: hsl(0, 100%, 40%);">-  pkt->soft_bits[bi.nbits + 1] = '\0';</span><br><span>   delete bi.rxBurst;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + bi.nbits + 2);</span><br><span style="color: hsl(120, 100%, 40%);">+  mDataSockets[chan]->write(burstString, sizeof(struct trxd_hdr_v0) + bi.nbits);</span><br><span> }</span><br><span> </span><br><span> void Transceiver::driveTxFIFO()</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-trx/+/14632">change 14632</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-trx/+/14632"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-trx </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iedc54011f333f48c6c8b81cab4d640f7601e01dd </div>
<div style="display:none"> Gerrit-Change-Number: 14632 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>