<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-mgw/+/14595">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">mgw: Support receiving uppercase connection mode<br><br>Change-Id: I4da93dfc69b5585a197a7e201a1afb72c2f97030<br>---<br>M src/libosmo-mgcp/mgcp_msg.c<br>M tests/mgcp/mgcp_test.c<br>M tests/mgcp/mgcp_test.ok<br>3 files changed, 6 insertions(+), 6 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-mgw refs/changes/95/14595/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/libosmo-mgcp/mgcp_msg.c b/src/libosmo-mgcp/mgcp_msg.c</span><br><span>index 59e0e91..44589d1 100644</span><br><span>--- a/src/libosmo-mgcp/mgcp_msg.c</span><br><span>+++ b/src/libosmo-mgcp/mgcp_msg.c</span><br><span>@@ -91,13 +91,13 @@</span><br><span>         if (!endp)</span><br><span>           return -1;</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  if (strcmp(mode, "recvonly") == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+  if (strcasecmp(mode, "recvonly") == 0)</span><br><span>             conn->mode = MGCP_CONN_RECV_ONLY;</span><br><span style="color: hsl(0, 100%, 40%);">-    else if (strcmp(mode, "sendrecv") == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+     else if (strcasecmp(mode, "sendrecv") == 0)</span><br><span>                conn->mode = MGCP_CONN_RECV_SEND;</span><br><span style="color: hsl(0, 100%, 40%);">-    else if (strcmp(mode, "sendonly") == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+     else if (strcasecmp(mode, "sendonly") == 0)</span><br><span>                conn->mode = MGCP_CONN_SEND_ONLY;</span><br><span style="color: hsl(0, 100%, 40%);">-    else if (strcmp(mode, "loopback") == 0)</span><br><span style="color: hsl(120, 100%, 40%);">+     else if (strcasecmp(mode, "loopback") == 0)</span><br><span>                conn->mode = MGCP_CONN_LOOPBACK;</span><br><span>  else {</span><br><span>               LOGPCONN(conn, DLMGCP, LOGL_ERROR,</span><br><span>diff --git a/tests/mgcp/mgcp_test.c b/tests/mgcp/mgcp_test.c</span><br><span>index c67b9d5..5a14bdf 100644</span><br><span>--- a/tests/mgcp/mgcp_test.c</span><br><span>+++ b/tests/mgcp/mgcp_test.c</span><br><span>@@ -165,7 +165,7 @@</span><br><span> </span><br><span> #define MDCX4_PT1 \</span><br><span>     "MDCX 18983217 1@mgw MGCP 1.0\r\n" \</span><br><span style="color: hsl(0, 100%, 40%);">-  "M: sendrecv\r" \</span><br><span style="color: hsl(120, 100%, 40%);">+   "M: SENDRECV\r" \</span><br><span>  "C: 2\r\n" \</span><br><span>       "I: %s\r\n" \</span><br><span>      "L: p:20-40, a:AMR, nt:IN\r\n" \</span><br><span>diff --git a/tests/mgcp/mgcp_test.ok b/tests/mgcp/mgcp_test.ok</span><br><span>index 08ea438..358a85c 100644</span><br><span>--- a/tests/mgcp/mgcp_test.ok</span><br><span>+++ b/tests/mgcp/mgcp_test.ok</span><br><span>@@ -125,7 +125,7 @@</span><br><span> creating message from statically defined input:</span><br><span> ---------8<---------</span><br><span> MDCX 18983217 1@mgw MGCP 1.0 </span><br><span style="color: hsl(0, 100%, 40%);">-M: sendrecv C: 2 </span><br><span style="color: hsl(120, 100%, 40%);">+M: SENDRECV C: 2 </span><br><span> I: %s </span><br><span> L: p:20-40, a:AMR, nt:IN </span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-mgw/+/14595">change 14595</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-mgw/+/14595"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-mgw </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I4da93dfc69b5585a197a7e201a1afb72c2f97030 </div>
<div style="display:none"> Gerrit-Change-Number: 14595 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>