<p>pespin has uploaded this change for <strong>review</strong>.</p><p><a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14609">View Change</a></p><pre style="font-family: monospace,monospace; white-space: pre-wrap;">bsc: Do proper chan release in TC_ho_out_fail_no_ho_detect<br><br>BSC waits to receive a ClearCommand in response to its ClearRequest<br>before it starts tearing down the MGCP conn on the MSC-side of the MGW<br>endpoint.<br><br>As a result, expected DLCX was not being sent which made test fail.<br><br>However, currently test still fails because current osmo-bsc master<br>sends a repeated ClearRequest message in this scenario.<br><br>Related: OS#4078<br>Change-Id: Ic398896147a0b6b04ffeae56a23d25783b2b17fe<br>---<br>M bsc/BSC_Tests.ttcn<br>1 file changed, 13 insertions(+), 11 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;">git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks refs/changes/09/14609/1</pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn</span><br><span>index f9609ba..88df9bc 100644</span><br><span>--- a/bsc/BSC_Tests.ttcn</span><br><span>+++ b/bsc/BSC_Tests.ttcn</span><br><span>@@ -2893,7 +2893,7 @@</span><br><span> }</span><br><span> </span><br><span> /* Expecting MGCP to DLCX the endpoint's two connections: towards BTS and towards MSC */</span><br><span style="color: hsl(0, 100%, 40%);">-private function f_expect_dlcx_conns(boolean exp_clear_cmpl := true) runs on MSC_ConnHdlr {</span><br><span style="color: hsl(120, 100%, 40%);">+private function f_expect_dlcx_conns() runs on MSC_ConnHdlr {</span><br><span>        var MgcpCommand mgcp;</span><br><span>        var template MgcpResponse mgcp_resp;</span><br><span>         var MGCP_RecvFrom mrf;</span><br><span>@@ -2923,9 +2923,7 @@</span><br><span>               };</span><br><span>   }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (exp_clear_cmpl) {</span><br><span style="color: hsl(0, 100%, 40%);">-           BSSAP.receive(tr_BSSMAP_ClearComplete);</span><br><span style="color: hsl(0, 100%, 40%);">- }</span><br><span style="color: hsl(120, 100%, 40%);">+     BSSAP.receive(tr_BSSMAP_ClearComplete);</span><br><span> }</span><br><span> </span><br><span> private function f_tc_ho_out_of_this_bsc(charstring id) runs on MSC_ConnHdlr {</span><br><span>@@ -2978,7 +2976,7 @@</span><br><span>   var BssmapCause cause := enum2int(cause_val);</span><br><span>        BSSAP.send(ts_BSSMAP_ClearCommand(cause));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  f_expect_dlcx_conns(true);</span><br><span style="color: hsl(120, 100%, 40%);">+    f_expect_dlcx_conns();</span><br><span>       setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span> }</span><br><span>@@ -3171,6 +3169,7 @@</span><br><span>    * RR should be released and Clear Request should go to the MSC. */</span><br><span> </span><br><span>      var MgcpCommand mgcp;</span><br><span style="color: hsl(120, 100%, 40%);">+ var PDU_BSSAP rx_clear_request;</span><br><span>      interleave {</span><br><span>         [] RSL.receive(tr_RSL_DEACT_SACCH(g_chan_nr)) {</span><br><span>                      log("Got Deact SACCH");</span><br><span>@@ -3182,12 +3181,15 @@</span><br><span>                  log("Got RF Chan Rel");</span><br><span>                    RSL.send(ts_RSL_RF_CHAN_REL_ACK(g_chan_nr));</span><br><span>                 }</span><br><span style="color: hsl(0, 100%, 40%);">-       [] BSSAP.receive(tr_BSSMAP_ClearRequest) {</span><br><span style="color: hsl(120, 100%, 40%);">+    [] BSSAP.receive(tr_BSSMAP_ClearRequest) -> value rx_clear_request {</span><br><span>                      log("Got BSSMAP Clear Request");</span><br><span style="color: hsl(120, 100%, 40%);">+                    /* Instruct BSC to clear channel */</span><br><span style="color: hsl(120, 100%, 40%);">+                   var BssmapCause cause := bit2int(rx_clear_request.pdu.bssmap.clearRequest.cause.causeValue);</span><br><span style="color: hsl(120, 100%, 40%);">+                  BSSAP.send(ts_BSSMAP_ClearCommand(cause));</span><br><span>           }</span><br><span>    }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   f_expect_dlcx_conns(false);</span><br><span style="color: hsl(120, 100%, 40%);">+   f_expect_dlcx_conns();</span><br><span> </span><br><span>   setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span>@@ -3332,7 +3334,7 @@</span><br><span>        var BssmapCause cause := enum2int(cause_val);</span><br><span>        BSSAP.send(ts_BSSMAP_ClearCommand(cause));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  f_expect_dlcx_conns(true);</span><br><span style="color: hsl(120, 100%, 40%);">+    f_expect_dlcx_conns();</span><br><span>       setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span> </span><br><span>@@ -3414,7 +3416,7 @@</span><br><span>    var BssmapCause cause := enum2int(cause_val);</span><br><span>        BSSAP.send(ts_BSSMAP_ClearCommand(cause));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  f_expect_dlcx_conns(true);</span><br><span style="color: hsl(120, 100%, 40%);">+    f_expect_dlcx_conns();</span><br><span>       setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span> }</span><br><span>@@ -3493,7 +3495,7 @@</span><br><span>   var BssmapCause cause := enum2int(cause_val);</span><br><span>        BSSAP.send(ts_BSSMAP_ClearCommand(cause));</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-  f_expect_dlcx_conns(true);</span><br><span style="color: hsl(120, 100%, 40%);">+    f_expect_dlcx_conns();</span><br><span>       setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span> </span><br><span>@@ -3566,7 +3568,7 @@</span><br><span>            var BssmapCause cause := bit2int(rx_clear_request.pdu.bssmap.clearRequest.cause.causeValue);</span><br><span>                 BSSAP.send(ts_BSSMAP_ClearCommand(cause));</span><br><span>   };</span><br><span style="color: hsl(0, 100%, 40%);">-      f_expect_dlcx_conns(true);</span><br><span style="color: hsl(120, 100%, 40%);">+    f_expect_dlcx_conns();</span><br><span>       setverdict(pass);</span><br><span>    f_sleep(1.0);</span><br><span> }</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14609">change 14609</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14609"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: osmo-ttcn3-hacks </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ic398896147a0b6b04ffeae56a23d25783b2b17fe </div>
<div style="display:none"> Gerrit-Change-Number: 14609 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: newchange </div>