<p><a href="https://gerrit.osmocom.org/c/docker-playground/+/14563">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.osmocom.org/#/c/14563/2/ttcn3-hlr-test/osmo-hlr.cfg">File ttcn3-hlr-test/osmo-hlr.cfg:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.osmocom.org/#/c/14563/2/ttcn3-hlr-test/osmo-hlr.cfg@24">Patch Set #2, Line 24:</a> <code style="font-family:monospace,monospace">log gsmtap 172.18.10.103</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I personally don't like having log in gsmtap, and I think we are not doing that in any test so far,  […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Is there any downside to having gsmtap in tests? I find it useful to have the logs in the same pcap file as the trace of the test, and if somebody gets distracted from it, they could simply filter it away in the wireshark UI.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I agree that having it the same for every test suite would be best.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.osmocom.org/c/docker-playground/+/14563">change 14563</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/docker-playground/+/14563"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: docker-playground </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ifb4a39e6e2987f4dc04369508fe0dff0913a02ff </div>
<div style="display:none"> Gerrit-Change-Number: 14563 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: fixeria <axilirator@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: laforge <laforge@gnumonks.org> </div>
<div style="display:none"> Gerrit-Reviewer: osmith <osmith@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-Comment-Date: Fri, 21 Jun 2019 12:59:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>