<p>Hoernchen <strong>merged</strong> this change.</p><p><a href="https://gerrit.osmocom.org/c/osmo-bts/+/14567">View Change</a></p><div style="white-space:pre-wrap">Approvals:
Hoernchen: Looks good to me, approved; Verified
pespin: Looks good to me, approved
</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">revert changes to T200<br><br>The timers are unfortunately completely broken, so let's go back to the<br>long default timeout values from 1ff0a2addd04de5bfe1601e84b013c65e500faf0<br><br>See related issues OS#4066 and OS#4074<br><br><br><br>Change-Id: Ia44310245a348675dbbf3ffc3dc5b6d207fd62d3<br>---<br>M src/common/oml.c<br>1 file changed, 17 insertions(+), 7 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/src/common/oml.c b/src/common/oml.c</span><br><span>index 8ecafbb..3defa49 100644</span><br><span>--- a/src/common/oml.c</span><br><span>+++ b/src/common/oml.c</span><br><span>@@ -479,13 +479,13 @@</span><br><span> /* The defaults below correspond to various sources/recommendations that could be found online.</span><br><span> * The BSC should override this via OML anyway. */</span><br><span> const unsigned int oml_default_t200_ms[7] = {</span><br><span style="color: hsl(0, 100%, 40%);">- [T200_SDCCH] = 220,</span><br><span style="color: hsl(0, 100%, 40%);">- [T200_SDCCH_SAPI3] = 450,</span><br><span style="color: hsl(0, 100%, 40%);">- [T200_SACCH_SDCCH] = 900,</span><br><span style="color: hsl(0, 100%, 40%);">- [T200_FACCH_F] = 250,</span><br><span style="color: hsl(0, 100%, 40%);">- [T200_FACCH_H] = 250,</span><br><span style="color: hsl(0, 100%, 40%);">- [T200_SACCH_TCH_SAPI0] = 1500,</span><br><span style="color: hsl(0, 100%, 40%);">- [T200_SACCH_TCH_SAPI3] = 1500,</span><br><span style="color: hsl(120, 100%, 40%);">+ [T200_SDCCH] = 1000,</span><br><span style="color: hsl(120, 100%, 40%);">+ [T200_FACCH_F] = 1000,</span><br><span style="color: hsl(120, 100%, 40%);">+ [T200_FACCH_H] = 1000,</span><br><span style="color: hsl(120, 100%, 40%);">+ [T200_SACCH_TCH_SAPI0] = 2000,</span><br><span style="color: hsl(120, 100%, 40%);">+ [T200_SACCH_SDCCH] = 2000,</span><br><span style="color: hsl(120, 100%, 40%);">+ [T200_SDCCH_SAPI3] = 1000,</span><br><span style="color: hsl(120, 100%, 40%);">+ [T200_SACCH_TCH_SAPI3] = 2000,</span><br><span> };</span><br><span> </span><br><span> /* 3GPP TS 52.021 ยง8.11.1 Get Attributes has been received */</span><br><span>@@ -626,10 +626,20 @@</span><br><span> payload = TLVP_VAL(&tp, NM_ATT_T200);</span><br><span> for (i = 0; i < ARRAY_SIZE(bts->t200_ms); i++) {</span><br><span> uint32_t t200_ms = payload[i] * abis_nm_t200_ms[i];</span><br><span style="color: hsl(120, 100%, 40%);">+#if 0</span><br><span> bts->t200_ms[i] = t200_ms;</span><br><span> DEBUGPFOH(DOML, foh, "T200[%u]: OML=%u, mult=%u => %u ms\n",</span><br><span> i, payload[i], abis_nm_t200_ms[i],</span><br><span> bts->t200_ms[i]);</span><br><span style="color: hsl(120, 100%, 40%);">+#else</span><br><span style="color: hsl(120, 100%, 40%);">+ /* we'd rather use the 1s/2s (long) defaults by</span><br><span style="color: hsl(120, 100%, 40%);">+ * libosmocore, as we appear to have some bug(s)</span><br><span style="color: hsl(120, 100%, 40%);">+ * related to handling T200 expiration in</span><br><span style="color: hsl(120, 100%, 40%);">+ * libosmogsm lapd(m) code? */</span><br><span style="color: hsl(120, 100%, 40%);">+ LOGPFOH(DOML, LOGL_NOTICE, foh, "Ignoring T200[%u] (%u ms) "</span><br><span style="color: hsl(120, 100%, 40%);">+ "as sent by BSC due to suspected LAPDm bug!\n",</span><br><span style="color: hsl(120, 100%, 40%);">+ i, t200_ms);</span><br><span style="color: hsl(120, 100%, 40%);">+#endif</span><br><span> }</span><br><span> }</span><br><span> </span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.osmocom.org/c/osmo-bts/+/14567">change 14567</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.osmocom.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.osmocom.org/c/osmo-bts/+/14567"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: osmo-bts </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia44310245a348675dbbf3ffc3dc5b6d207fd62d3 </div>
<div style="display:none"> Gerrit-Change-Number: 14567 </div>
<div style="display:none"> Gerrit-PatchSet: 3 </div>
<div style="display:none"> Gerrit-Owner: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> </div>
<div style="display:none"> Gerrit-Reviewer: Jenkins Builder </div>
<div style="display:none"> Gerrit-Reviewer: pespin <pespin@sysmocom.de> </div>
<div style="display:none"> Gerrit-MessageType: merged </div>